From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1ihdzK-0000NS-Fm for mharc-grub-devel@gnu.org; Wed, 18 Dec 2019 13:23:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57210) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihdzH-0000LC-2R for grub-devel@gnu.org; Wed, 18 Dec 2019 13:23:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ihdzF-0004PA-Fc for grub-devel@gnu.org; Wed, 18 Dec 2019 13:23:54 -0500 Received: from mout.gmx.net ([212.227.17.21]:52743) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ihdzE-0004EF-48 for grub-devel@gnu.org; Wed, 18 Dec 2019 13:23:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1576693428; bh=iBHDfO3rL22Htfa2gkj9O7ifuDMEvl9TK8e/rVxK+D4=; h=X-UI-Sender-Class:Date:From:To:Subject; b=PfpCGxIHvr6s8eSogOePe3mzuc8oMM8xI84zCNypzPIOM9U4d/3/uUNwW62XescP7 Areej9G0DOcW7CZzSyZsvMjUkhsuBjpknALHFYCxe0iazVgdtnnxNoqpeGCLZEz1OQ 5uR0T3RfHSnghY24EPVNF/LeN17f6MH7ZvWU4edg= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from scdbackup.webframe.org ([91.8.168.145]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M4JmT-1ihv6L25zt-000OXI for ; Wed, 18 Dec 2019 19:23:48 +0100 Date: Wed, 18 Dec 2019 19:24:45 +0100 From: "Thomas Schmitt" To: grub-devel@gnu.org Subject: grub-mkrescue: The blkid LABELs of its ISO 9660, HFS+, FAT filesystems Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <1221694109649607190@scdbackup.webframe.org> X-Provags-ID: V03:K1:us+HQzGlOl6DnJpG3xWBMjY5dQGrONGixdTTeM5rPemIhVcnZPR 5lJ7jVjJ/x63UtbzmZYJZxte9BRqD0YE3xaunZr0bJoFOvLiv2v4Fl9NpOA6Kp6ccsgIKTT Yfl2to7QcmrstC6LM4OUGS5M8h3AP6er0oCHxlrf3se07u5SeglBuftdUl3pCyxa46IAqVj wMHjEOr1j75mZuOci3UDg== X-UI-Out-Filterresults: notjunk:1;V03:K0:aiVFXcyfsME=:eeetxNGWsYfVn3pY6S/BKJ goKKzhnBU106P0osFAZKMXFKtau8r2BA1hhz97Yy/fvqhlN2eOXWEzvbx39PJEqTRgRj2v9WT XowuIoxTM1k+qwuQi5j9lkhieF23ZnRwXxMFgeEUafIgAm0kd/O10OHWS20niVYw+iflF0CFp c6sHh4ZA5wYTHnaMD4aNpHlwYOKbsmKLI8h/DbqGbTGfKHCyTq5bH+8Cfq+WvUWpyzP/wLQuh vAoScJQgyOITzORtwZKz8HQOTtIXwS4zUqZdeMl6gkZaK4HmF0E9YvtuTWlEDrGJKe+KRmZhg 25yr4VNl+GxETY6meqL68z2/aQy8jkl7rNfDq0sf78ZzdhpEXoSujaaHbvjFTY+b688fVYOSv MtLlGv6u8RGHGMjt5D/Ohmb151fh50fp5Op1VZnEd6nXx+QJQua9CdIUk+T68vRZV/zhHY2MK DrY6Pn0Lx9rByrbxrFT7brPXDKX5uniK/goBPP01HIj9/JZkLHC+bwZGaLKDGqE24sCmTfYxI O1T4BuUBOhkxw2KOYogWr6JU0OFLGqRzzrtVgKCbziVfWiTGwvHzut9oVukeiz2Z16W6Q+LGY 0qyo3MASbjME3bX+utqB07n9pRYOMkeTqAOEwxnguMHnS05eRXPWfQmkXGedvZKXyU/BgOYet qc4+pDLMDNOBZZS1Njxnl4a64kYXj8ElKU4Jkpu6uPwOtcVgqLZxtIrej9LbyxzTdw4gRIxuY JyC2FAj/R535TDWYpNxnc4FaHjoADJRdlPiyXWL2v+uuQltb53/CPG2i93HtranShmB3O+6tn K6qD2HB+1SH6A7jjFDEgMX5G2jmOC8Fk10CBW0gSPHToXVuQGu5VSLHYdW1GHybzKeEFV6GGE ZrbvvIpYCQTn0LqRO30HRgazDvONF0i+usxwxq2ssI/A2PO4s52cQzj9heN0oSKYVEOgycLJX ahueSCbG7bjUPlUF+wYff15kgCTVVRabI6iDUk08h81bw8uw5XTQ1dgPHLm2BgSwVYG145jQw Z4yre1j3sH84aLRCnI/BsqFyuEvGac2pXlIIyYNAYXambu8f5UGtCQLn9anPL3xrY+y51PLyA MjI41B9EwXur/MHK7uOREuV9D3x5kAyILd7FGxs0oS+PhTHHaGEgqLqDKownxmCmNzgR2O33c 2Z1SGk6kNm3t+Ca1RvoxnBJJwmSvgzIHpNuOvySru/sVxfeD9OzRfkGzO27gvO2uVUoU+V82P oix/H36Ae8yFK3rJdkqDzFTUHBkLPUCFLqeAcA7D2uA4+x/B9xCYbpGX1wiQ= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.17.21 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Dec 2019 18:23:56 -0000 Hi, during tests about the changes in blkid which are still discussed in https://github.com/karelzak/util-linux/pull/913 i noted that a grub-mkrescue ISO for x86 BIOS and EFI shows the same filesystem label with its ISO 9660 and HFS+ filesystem superblocks. # lsblk -o NAME,FSTYPE,LABEL /dev/sdd NAME FSTYPE LABEL sdd iso9660 ISOIMAGE =E2=94=9C=E2=94=80sdd1 =E2=94=9C=E2=94=80sdd2 vfat =E2=94=9C=E2=94=80sdd3 hfsplus ISOIMAGE =E2=94=94=E2=94=80sdd4 On Linux this causes a name collision when udev creates /dev/disk/by-label links. Usually HFS+ wins. But that's not guaranteed. The label identity is currently hardcoded in libisofs. The code stems from Vladimir Serbinenko. I am in charge of maintaining it, though. See https://sources.debian.org/src/libisofs/1.5.2-1/libisofs/hfsplus.c/#L163= 2 ret =3D set_hfsplus_name (target, target->image->volume_id, &target->hfsp_leafs[target->hfsp_curleaf]); It looks like the Volume Id from the libisofs ISO 9660 model is set as name of HFS+ node target->hfsp_leafs[0]. I guess this is the root node. Whatever, it is the only occurence of volume_id in Vladimir's code. Thus this line must be the gateway of "LABEL" between libisofs settings and HFS+ metadata production. ("ISOIMAGE" is the default Volume Id of xorriso.) =2D-----------------------------------------------------------------------= -- So what to do ? [ ] Leave both labels identical and continue to confuse users via udev. [ ] Change HFS+ LABEL automatically by adding "_HFSPLUS" to the upto 32 characters of Volume Id. [ ] Have independent setting and default of HFS+ LABEL in libisofs. This is most flexible but also creates new duties for the users of grub-mkrescue, if both LABELs have to be unique in comparison to other filesystems on other devices. I would vote for the middle alternative, if i had any experience with HFS+ beyond hosting Vladimir's code in libisofs. Vladimir ? Anybody else with HFS+ experience ? =2D-----------------------------------------------------------------------= -- Further: Should grub-mkrescue give the EFI FAT filesystem a LABEL, too ? man mformat says about option -v v Specifies the volume label. A volume label identifies the disk and can be a maximum of 11 characters. If you omit the -v switch, mformat will assign no label to the disk. "GRUBMKR_EFI" ? On the other hand, no LABEL means no label problems. Have a nice day :) Thomas