From: "Benjamin Li" <benli@broadcom.com>
To: "Jeff Garzik" <jeff@garzik.org>
Cc: benli@broadcom.com, "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: [UPDATED][NET-NEXT PATCH 1/4] bnx2: In bnx2_set_mac_link() return void rather then int
Date: Thu, 18 Sep 2008 09:57:10 -0700 [thread overview]
Message-ID: <1221757033-4874-2-git-send-email-benli@broadcom.com> (raw)
In-Reply-To: <1221757033-4874-1-git-send-email-benli@broadcom.com>
bnx2_set_mac_link() doesn't need to return any error codes. And
all the callers don't check the return code. It is safe to
change the return type to a void.
Signed-off-by: Benjamin Li <benli@broadcom.com>
Signed-off-by: Michael Chan <mchan@broadcom.com>
---
drivers/net/bnx2.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 2486a65..192a24e 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -1127,7 +1127,7 @@ bnx2_init_all_rx_contexts(struct bnx2 *bp)
}
}
-static int
+static void
bnx2_set_mac_link(struct bnx2 *bp)
{
u32 val;
@@ -1193,8 +1193,6 @@ bnx2_set_mac_link(struct bnx2 *bp)
if (CHIP_NUM(bp) == CHIP_NUM_5709)
bnx2_init_all_rx_contexts(bp);
-
- return 0;
}
static void
--
1.6.0.1
next prev parent reply other threads:[~2008-09-18 16:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080918063933.GA8027@verge.net.au>
2008-09-18 16:57 ` [UPDATED][NET-NEXT PATCH 0/4] Minor bnx2 patches Benjamin Li
2008-09-18 16:57 ` Benjamin Li [this message]
2008-09-18 16:57 ` [UPDATED][NET-NEXT PATCH 2/4] bnx2: Update MODULE_DESCRIPTION to include the 5716 Benjamin Li
2008-09-18 16:57 ` [UPDATED][NET-NEXT PATCH 3/4] bnx2: Remove name field from bnx2 structure Benjamin Li
2008-09-18 16:57 ` [UPDATED][NET-NEXT PATCH 4/4] bnx2: Remove timer_interval field from the " Benjamin Li
2008-09-18 23:40 ` David Miller
2008-09-18 23:40 ` [UPDATED][NET-NEXT PATCH 3/4] bnx2: Remove name field from " David Miller
2008-09-18 22:29 ` [UPDATED][NET-NEXT PATCH 2/4] bnx2: Update MODULE_DESCRIPTION to include the 5716 David Miller
2008-09-18 23:39 ` David Miller
2008-09-18 23:38 ` [UPDATED][NET-NEXT PATCH 1/4] bnx2: In bnx2_set_mac_link() return void rather then int David Miller
2008-09-18 17:04 ` [UPDATED][NET-NEXT PATCH 0/4] Minor bnx2 patches Jeff Garzik
2008-09-18 22:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1221757033-4874-2-git-send-email-benli@broadcom.com \
--to=benli@broadcom.com \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.