From: Felix Zielcke <fzielcke@z-51.de>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] update configure.ac to autoconf 2.61
Date: Sun, 21 Sep 2008 19:39:04 +0200 [thread overview]
Message-ID: <1222018744.4080.5.camel@fz.local> (raw)
In-Reply-To: <1220514312.4167.9.camel@fz.local>
Well, commited.
Am Donnerstag, den 04.09.2008, 09:45 +0200 schrieb Felix Zielcke:
> Am Mittwoch, den 03.09.2008, 19:43 -0400 schrieb Pavel Roskin:
> >
> > I don't see any old stuff being removed. I don't see any justification
> > for any of the changes. The new code is longer and less readable. I
> > don't think AC_TRY_COMPILE is a big problem yet. It's not like it won't
> > produce a valid test.
>
> http://www.gnu.org/software/autoconf/manual/autoconf.html#Autoconf-Macro-Index
>
> AC_TRY_COMPILE is listed as `Obsolete Macro'.
>
> I attached now even a diff with autoconf 2.62 which I won't commit, but
> maybe you or someone else is interested.
> Changelog says AC_GNU_SOURCE has been deprecated, though they're
> currently no plans to remove it.
>
> Currently it's not really needed but things get easily forgotten, even I
> myself forgot a patch from me ..
> We don't need to discuss running `autoupdate' in ./autogen.sh this is
> really bad.
> The Debian Build System has such a feature too but ftp-masters' reject
> packages which uses it by default.
>
> You only need to run autoconf -Wall then you see.
> Ok they're not shown by default, but I don't like to have obsolte
> deprecated stuff if it can be easily avoided like in this case.
>
> > In any case, please try to avoid extra long lines where it can be easily
> > avoided.
>
> I hope the intention is now right, Emacs had a problem with it.
>
> > Okuji wrote that he uses Autoconf 2.59, so it would be nice to check
> > that your changes would still work with that version.
>
> Luckly it's still avaible in Debian oldstable (sarge)
> newest CentOS 5.2 even still has autoconf 2.59
> Changes are the same as with 2.61 so 2.59 seems to be fine.
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
prev parent reply other threads:[~2008-09-21 17:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-03 13:27 [PATCH] update configure.ac to autoconf 2.61 Felix Zielcke
2008-09-03 14:51 ` Felix Zielcke
2008-09-03 23:47 ` Pavel Roskin
2008-09-04 7:55 ` Felix Zielcke
2008-09-03 23:43 ` Pavel Roskin
2008-09-04 7:45 ` Felix Zielcke
2008-09-04 16:49 ` Pavel Roskin
2008-09-04 17:32 ` Felix Zielcke
2008-09-21 17:39 ` Felix Zielcke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1222018744.4080.5.camel@fz.local \
--to=fzielcke@z-51.de \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.