From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753519AbYIVQiX (ORCPT ); Mon, 22 Sep 2008 12:38:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751140AbYIVQiP (ORCPT ); Mon, 22 Sep 2008 12:38:15 -0400 Received: from casper.infradead.org ([85.118.1.10]:58234 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750913AbYIVQiP (ORCPT ); Mon, 22 Sep 2008 12:38:15 -0400 Subject: Re: Unified tracing buffer From: Peter Zijlstra To: Martin Bligh Cc: prasad@linux.vnet.ibm.com, Linux Kernel Mailing List , Linus Torvalds , Thomas Gleixner , Mathieu Desnoyers , Steven Rostedt , od@novell.com, "Frank Ch. Eigler" , Andrew Morton , hch@lst.de, David Wilder , zanussi@comcast.net In-Reply-To: <33307c790809220929l32427a1as3d6d6bc08ce3173b@mail.gmail.com> References: <33307c790809191433w246c0283l55a57c196664ce77@mail.gmail.com> <1221869279.8359.31.camel@lappy.programming.kicks-ass.net> <20080922140740.GB5279@in.ibm.com> <1222094724.16700.11.camel@lappy.programming.kicks-ass.net> <33307c790809220929l32427a1as3d6d6bc08ce3173b@mail.gmail.com> Content-Type: text/plain Date: Mon, 22 Sep 2008 18:36:41 +0200 Message-Id: <1222101401.16700.48.camel@lappy.programming.kicks-ass.net> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2008-09-22 at 09:29 -0700, Martin Bligh wrote: > >> In conjunction with the previous email on this thread > >> (http://lkml.org/lkml/2008/9/22/160), may I suggest > >> the equivalent interfaces in -mm tree (2.6.27-rc5-mm1) to be: > >> > >> relay_printk(, , > >> ....) ; > >> relay_dump(, >> data>); > >> and > >> relay_cleanup_all(); - Single interface that cleans up > >> all files/directories/output data created under a logical entity. > > > > Dude, relayfs is such a bad performing mess that extending it seems like > > a bad idea. Better to write something new and delete everything relayfs > > related. > > There did seem to be pretty universal agreement that we'd rather not > use relayfs. > > > Also, it seems prudent to separate the ring-buffer implementation from > > the event encoding/decoding facilities. > > Right - in conversation I had with Mathieu later, he suggested cleaning up > relayfs - I fear this will delay us far too long, and get bogged down. > If we can get one clean circular buffer implementation, then both > relayfs and the tracing could share that common solution, Currently only blktrace and kvmtrace use relayfs, and I've heard people talk about converting both to use lttng/ftrace infrastructure. At which point relayfs is orphaned and ready for removal.