From mboxrd@z Thu Jan 1 00:00:00 1970 From: laurent.pinchart@ideasonboard.com (Laurent Pinchart) Date: Mon, 31 Oct 2016 22:22:54 +0200 Subject: [PATCH v2 4/5] ARM: dts: da850-lcdk: enable mstpri and ddrctl nodes In-Reply-To: <1477925138-23457-5-git-send-email-bgolaszewski@baylibre.com> References: <1477925138-23457-1-git-send-email-bgolaszewski@baylibre.com> <1477925138-23457-5-git-send-email-bgolaszewski@baylibre.com> Message-ID: <12222113.L5elJM2tqN@avalon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Bartosz, Thank you for the patch. On Monday 31 Oct 2016 15:45:37 Bartosz Golaszewski wrote: > Enable the MSTPRI configuration and DDR2/mDDR memory controller > nodes on da850-lcdk. This is needed in order to adjust the memory > throughput constraints for better tilcdc support. Is there a reason not to enable these unconditionally in da850.dtsi (or rather not disabling them) instead of handling it per board ? > Signed-off-by: Bartosz Golaszewski > --- > arch/arm/boot/dts/da850-lcdk.dts | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/boot/dts/da850-lcdk.dts > b/arch/arm/boot/dts/da850-lcdk.dts index 4747629..b39796e 100644 > --- a/arch/arm/boot/dts/da850-lcdk.dts > +++ b/arch/arm/boot/dts/da850-lcdk.dts > @@ -243,3 +243,11 @@ > }; > }; > }; > + > +&mstpri { > + status = "okay"; > +}; > + > +&ddrctl { > + status = "okay"; > +}; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2 4/5] ARM: dts: da850-lcdk: enable mstpri and ddrctl nodes Date: Mon, 31 Oct 2016 22:22:54 +0200 Message-ID: <12222113.L5elJM2tqN@avalon> References: <1477925138-23457-1-git-send-email-bgolaszewski@baylibre.com> <1477925138-23457-5-git-send-email-bgolaszewski@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1477925138-23457-5-git-send-email-bgolaszewski@baylibre.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Bartosz Golaszewski Cc: Mark Rutland , linux-devicetree , Tomi Valkeinen , Kevin Hilman , Michael Turquette , Sekhar Nori , Russell King , linux-drm , LKML , Peter Ujfalusi , Rob Herring , Jyri Sarha , Frank Rowand , arm-soc List-Id: devicetree@vger.kernel.org SGkgQmFydG9zeiwKClRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoLgoKT24gTW9uZGF5IDMxIE9jdCAy MDE2IDE1OjQ1OjM3IEJhcnRvc3ogR29sYXN6ZXdza2kgd3JvdGU6Cj4gRW5hYmxlIHRoZSBNU1RQ UkkgY29uZmlndXJhdGlvbiBhbmQgRERSMi9tRERSIG1lbW9yeSBjb250cm9sbGVyCj4gbm9kZXMg b24gZGE4NTAtbGNkay4gVGhpcyBpcyBuZWVkZWQgaW4gb3JkZXIgdG8gYWRqdXN0IHRoZSBtZW1v cnkKPiB0aHJvdWdocHV0IGNvbnN0cmFpbnRzIGZvciBiZXR0ZXIgdGlsY2RjIHN1cHBvcnQuCgpJ cyB0aGVyZSBhIHJlYXNvbiBub3QgdG8gZW5hYmxlIHRoZXNlIHVuY29uZGl0aW9uYWxseSBpbiBk YTg1MC5kdHNpIChvciByYXRoZXIgCm5vdCBkaXNhYmxpbmcgdGhlbSkgaW5zdGVhZCBvZiBoYW5k bGluZyBpdCBwZXIgYm9hcmQgPwoKPiBTaWduZWQtb2ZmLWJ5OiBCYXJ0b3N6IEdvbGFzemV3c2tp IDxiZ29sYXN6ZXdza2lAYmF5bGlicmUuY29tPgo+IC0tLQo+ICBhcmNoL2FybS9ib290L2R0cy9k YTg1MC1sY2RrLmR0cyB8IDggKysrKysrKysKPiAgMSBmaWxlIGNoYW5nZWQsIDggaW5zZXJ0aW9u cygrKQo+IAo+IGRpZmYgLS1naXQgYS9hcmNoL2FybS9ib290L2R0cy9kYTg1MC1sY2RrLmR0cwo+ IGIvYXJjaC9hcm0vYm9vdC9kdHMvZGE4NTAtbGNkay5kdHMgaW5kZXggNDc0NzYyOS4uYjM5Nzk2 ZSAxMDA2NDQKPiAtLS0gYS9hcmNoL2FybS9ib290L2R0cy9kYTg1MC1sY2RrLmR0cwo+ICsrKyBi L2FyY2gvYXJtL2Jvb3QvZHRzL2RhODUwLWxjZGsuZHRzCj4gQEAgLTI0MywzICsyNDMsMTEgQEAK PiAgCQl9Owo+ICAJfTsKPiAgfTsKPiArCj4gKyZtc3Rwcmkgewo+ICsJc3RhdHVzID0gIm9rYXki Owo+ICt9Owo+ICsKPiArJmRkcmN0bCB7Cj4gKwlzdGF0dXMgPSAib2theSI7Cj4gK307CgotLSAK UmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030486AbcJaUXD (ORCPT ); Mon, 31 Oct 2016 16:23:03 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:47315 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030412AbcJaUXA (ORCPT ); Mon, 31 Oct 2016 16:23:00 -0400 From: Laurent Pinchart To: Bartosz Golaszewski Cc: Kevin Hilman , Michael Turquette , Sekhar Nori , Rob Herring , Frank Rowand , Mark Rutland , Peter Ujfalusi , Russell King , LKML , arm-soc , linux-drm , linux-devicetree , Jyri Sarha , Tomi Valkeinen , David Airlie Subject: Re: [PATCH v2 4/5] ARM: dts: da850-lcdk: enable mstpri and ddrctl nodes Date: Mon, 31 Oct 2016 22:22:54 +0200 Message-ID: <12222113.L5elJM2tqN@avalon> User-Agent: KMail/4.14.10 (Linux/4.4.26-gentoo; KDE/4.14.24; x86_64; ; ) In-Reply-To: <1477925138-23457-5-git-send-email-bgolaszewski@baylibre.com> References: <1477925138-23457-1-git-send-email-bgolaszewski@baylibre.com> <1477925138-23457-5-git-send-email-bgolaszewski@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bartosz, Thank you for the patch. On Monday 31 Oct 2016 15:45:37 Bartosz Golaszewski wrote: > Enable the MSTPRI configuration and DDR2/mDDR memory controller > nodes on da850-lcdk. This is needed in order to adjust the memory > throughput constraints for better tilcdc support. Is there a reason not to enable these unconditionally in da850.dtsi (or rather not disabling them) instead of handling it per board ? > Signed-off-by: Bartosz Golaszewski > --- > arch/arm/boot/dts/da850-lcdk.dts | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/boot/dts/da850-lcdk.dts > b/arch/arm/boot/dts/da850-lcdk.dts index 4747629..b39796e 100644 > --- a/arch/arm/boot/dts/da850-lcdk.dts > +++ b/arch/arm/boot/dts/da850-lcdk.dts > @@ -243,3 +243,11 @@ > }; > }; > }; > + > +&mstpri { > + status = "okay"; > +}; > + > +&ddrctl { > + status = "okay"; > +}; -- Regards, Laurent Pinchart