From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Benny Halevy <bhalevy@panasas.com>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
Olga Kornievskaia <aglo@citi.umich.edu>,
linux-nfs@vger.kernel.org, pnfs mailing list <pnfs@linux-nfs.org>,
Trond Myklebust <trond@netapp.com>
Subject: Re: [pnfs] [PATCH] nfsd: use nfs client rpc callback program
Date: Thu, 25 Sep 2008 16:08:58 -0400 [thread overview]
Message-ID: <1222373338.13388.19.camel@localhost> (raw)
In-Reply-To: <48DBE6D9.3010603@panasas.com>
On Thu, 2008-09-25 at 22:30 +0300, Benny Halevy wrote:
> One more thing that seems to need fixing is rpc_bind_new_program
> which now uses the passed-in program->cl_stats but doesn't point
> to the passed-in program, but rather it only extracts its
> name, number, and stats.
> Since program->stats may possibly go away with the program
> in the refcounted world I think we should get a reference on the
> program here too.
>
> That observed, it may also be a good idea to get rid of clnt->cl_stats
> altogether and use clnt->program->stats instead to prevent any
> discrepancy.
No. cl_stats are _per_client_ stats. program->stats are per protocol.
You can't just substitute one for the other.
Trond
next prev parent reply other threads:[~2008-09-25 20:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-17 19:43 [PATCH] nfsd: use nfs client rpc callback program Benny Halevy
2008-09-17 23:10 ` J. Bruce Fields
2008-09-17 23:34 ` Benny Halevy
2008-09-18 0:10 ` [pnfs] " Benny Halevy
2008-09-18 19:24 ` Benny Halevy
2008-09-18 19:43 ` Peter Staubach
2008-09-18 20:05 ` Benny Halevy
2008-09-18 21:36 ` Benny Halevy
2008-09-24 16:35 ` J. Bruce Fields
2008-09-24 16:59 ` Trond Myklebust
2008-09-24 17:21 ` J. Bruce Fields
2008-09-24 17:26 ` Trond Myklebust
2008-09-24 17:42 ` J. Bruce Fields
2008-09-24 18:42 ` Trond Myklebust
2008-09-24 18:49 ` J. Bruce Fields
2008-09-25 19:30 ` Benny Halevy
2008-09-25 20:00 ` J. Bruce Fields
2008-09-25 20:27 ` Trond Myklebust
2008-09-25 20:41 ` J. Bruce Fields
2008-09-26 11:52 ` Benny Halevy
2008-09-27 3:34 ` J. Bruce Fields
2008-09-28 6:21 ` [PATCH v4] " Benny Halevy
2008-09-29 19:21 ` J. Bruce Fields
2008-09-25 20:08 ` Trond Myklebust [this message]
2008-09-25 20:38 ` [pnfs] [PATCH] " J. Bruce Fields
2008-09-19 19:51 ` Olga Kornievskaia
2008-09-19 21:15 ` Benny Halevy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1222373338.13388.19.camel@localhost \
--to=trond.myklebust@fys.uio.no \
--cc=aglo@citi.umich.edu \
--cc=bfields@fieldses.org \
--cc=bhalevy@panasas.com \
--cc=linux-nfs@vger.kernel.org \
--cc=pnfs@linux-nfs.org \
--cc=trond@netapp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.