From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: MPC5200 PCI interrupt routing
Date: Fri, 26 Sep 2008 07:41:22 +1000 [thread overview]
Message-ID: <1222378882.8277.198.camel@pasglop> (raw)
In-Reply-To: <20080925165423.GA16018@secretlab.ca>
> I hadn't really wanted to go down this route because the calculation of
> the clock, or the decision to use an external clock or calculate an
> internal clock is very board specific. I'll need to take another look
> to decide if it is reasonable to encode it into the device tree.
Could be done using the feature call mechanism that I have for
powermac... though using a proper clock framework might be better in the
long run.
> > I tend to thing that drivers should deal with their own clocks. In fact
> > it would be nice if one could stop the clocks while the host port is in
> > suspend no ?
>
> Yeah, but in this case the clock can't actually be turned off. It's
> just a select bit between internal or external clock and a calculation
> value on the divider. Since it's a one-time board level setup
> config in a big block of shared chip level registers I'd rather just
> leave it in the domain of firmware.
Ah ok, makes more sense to keep it there then, or in platform init.
Ben.
prev parent reply other threads:[~2008-09-25 21:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-22 13:56 MPC5200 PCI interrupt routing Juergen Beisert
2008-09-22 15:12 ` Juergen Beisert
2008-09-22 21:01 ` Matt Sealey
2008-09-23 11:34 ` Juergen Beisert
2008-09-24 15:16 ` Juergen Beisert
2008-09-24 18:15 ` Grant Likely
2008-09-24 21:22 ` Benjamin Herrenschmidt
2008-09-24 21:34 ` Jon Smirl
2008-09-25 7:51 ` Juergen Beisert
2008-09-25 8:34 ` Benjamin Herrenschmidt
2008-09-25 16:57 ` Grant Likely
2008-09-25 18:02 ` Jon Smirl
2008-09-25 18:12 ` Grant Likely
2008-09-25 16:54 ` Grant Likely
2008-09-25 21:41 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1222378882.8277.198.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=grant.likely@secretlab.ca \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.