From: Michael Witten <mfwitten@MIT.EDU>
To: git@vger.kernel.org
Cc: Jeff King <peff@peff.net>
Subject: [RFC2 9/9] send-email: signedoffcc -> signedoffbycc, but handle both
Date: Mon, 29 Sep 2008 12:41:06 -0500 [thread overview]
Message-ID: <1222710066-57768-2-git-send-email-mfwitten@mit.edu> (raw)
In-Reply-To: <1222710066-57768-1-git-send-email-mfwitten@mit.edu>
The documentation now mentions sendemail.signedoffbycc instead
of sendemail.signedoffcc in order to match with the options
--signed-off-by-cc; the code has been updated to reflect this
as well, but sendemail.signedoffcc is still handled.
Signed-off-by: Michael Witten <mfwitten@mit.edu>
---
Documentation/git-send-email.txt | 2 +-
git-send-email.perl | 9 +++++----
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt
index d566c34..82f5056 100644
--- a/Documentation/git-send-email.txt
+++ b/Documentation/git-send-email.txt
@@ -144,7 +144,7 @@ Automating
--[no-]signed-off-by-cc::
If this is set, add emails found in Signed-off-by: or Cc: lines to the
- cc list. Default is the value of 'sendemail.signedoffcc' configuration
+ cc list. Default is the value of 'sendemail.signedoffbycc' configuration
value; if that is unspecified, default to --signed-off-by-cc.
--suppress-cc::
diff --git a/git-send-email.perl b/git-send-email.perl
index 80dae88..bdbfac6 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -151,7 +151,7 @@ if ($@) {
my ($quiet, $dry_run) = (0, 0);
# Variables with corresponding config settings
-my ($thread, $chain_reply_to, $suppress_from, $signed_off_cc, $cc_cmd);
+my ($thread, $chain_reply_to, $suppress_from, $signed_off_by_cc, $cc_cmd);
my ($smtp_server, $smtp_server_port, $smtp_authuser, $smtp_encryption);
my ($identity, $aliasfiletype, @alias_files, @smtp_host_parts);
my ($validate);
@@ -161,7 +161,8 @@ my %config_bool_settings = (
"thread" => [\$thread, 1],
"chainreplyto" => [\$chain_reply_to, 1],
"suppressfrom" => [\$suppress_from, undef],
- "signedoffcc" => [\$signed_off_cc, undef],
+ "signedoffbycc" => [\$signed_off_by_cc, undef],
+ "signedoffcc" => [\$signed_off_by_cc, undef], # Deprecated
"validate" => [\$validate, 1],
);
@@ -225,7 +226,7 @@ my $rc = GetOptions("sender|from=s" => \$sender,
"cc-cmd=s" => \$cc_cmd,
"suppress-from!" => \$suppress_from,
"suppress-cc=s" => \@suppress_cc,
- "signed-off-cc|signed-off-by-cc!" => \$signed_off_cc,
+ "signed-off-cc|signed-off-by-cc!" => \$signed_off_by_cc,
"dry-run" => \$dry_run,
"envelope-sender=s" => \$envelope_sender,
"thread!" => \$thread,
@@ -301,7 +302,7 @@ if ($suppress_cc{'all'}) {
# If explicit old-style ones are specified, they trump --suppress-cc.
$suppress_cc{'self'} = $suppress_from if defined $suppress_from;
-$suppress_cc{'sob'} = !$signed_off_cc if defined $signed_off_cc;
+$suppress_cc{'sob'} = !$signed_off_by_cc if defined $signed_off_by_cc;
# Debugging, print out the suppressions.
if (0) {
--
1.6.0.2.304.gdcf23.dirty
next prev parent reply other threads:[~2008-09-29 17:42 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-28 1:09 [PATCH 1/8] Docs: send-email's usage text and man page mention same options Michael Witten
2008-09-28 1:09 ` [PATCH 2/8] Docs: send-email usage text much sexier Michael Witten
2008-09-28 1:09 ` [PATCH 3/8] Docs: send-email: Man page option ordering Michael Witten
2008-09-28 1:09 ` [PATCH 4/8] send-email: change --no-validate to boolean --[no-]validate Michael Witten
2008-09-28 1:09 ` [PATCH 5/8] Docs: send-email: --chain_reply_to -> --[no-]chain-reply-to Michael Witten
2008-09-28 1:09 ` [PATCH 6/8] Docs: Arranged config options in man page Michael Witten
2008-09-28 1:09 ` [PATCH 7/8] Docs: send-email: Added all config variables to man end Michael Witten
2008-09-28 1:09 ` [PATCH 8/8] Docs: config: send-email config options included Michael Witten
2008-09-28 3:24 ` Jeff King
2008-09-28 19:03 ` Michael Witten
2008-09-28 19:06 ` Jeff King
2008-09-28 3:18 ` [PATCH 7/8] Docs: send-email: Added all config variables to man end Jeff King
2008-09-28 19:03 ` Michael Witten
2008-09-28 19:08 ` Jeff King
2008-09-28 3:15 ` [PATCH 6/8] Docs: Arranged config options in man page Jeff King
2008-09-28 19:03 ` Michael Witten
2008-09-28 4:51 ` [PATCH] bash completion: Add --[no-]-validate to "git send-email" Teemu Likonen
2008-09-28 12:55 ` Teemu Likonen
2008-09-28 8:08 ` [PATCH 3/8] Docs: send-email: Man page option ordering Jakub Narebski
2008-09-28 19:04 ` Michael Witten
2008-09-29 0:10 ` Jakub Narebski
2008-09-29 0:36 ` Jeff King
2008-09-29 5:08 ` [RFC 6/9] Docs: send-email: Remove unnecessary config variable description Michael Witten
2008-09-29 5:08 ` [RFC 7/9] send-email: Completely replace --signed-off-cc with --signed-off-by-cc Michael Witten
2008-09-29 5:08 ` [RFC 8/9] Docs: send-email: Create logical groupings for --help text Michael Witten
2008-09-29 5:08 ` [RFC 9/9] Docs: send-email: Create logical groupings for man text Michael Witten
2008-09-29 16:25 ` [RFC 8/9] Docs: send-email: Create logical groupings for --help text Jeff King
[not found] ` <1222664781-55763-1-git-send-email-mfwitten@mit.edu>
[not found] ` <1222664781-55763-2-git-send-email-mfwitten@mit.edu>
2008-09-29 16:29 ` [RFC 7/9] send-email: Completely replace --signed-off-cc with --signed-off-by-cc Jeff King
2008-09-29 17:41 ` [RFC2 8/9] Docs: send-email: Create logical groupings for man text Michael Witten
2008-09-29 17:41 ` Michael Witten [this message]
2008-09-29 17:44 ` [RFC2 9/9] send-email: signedoffcc -> signedoffbycc, but handle both Jeff King
2008-09-30 12:58 ` [PATCH 1/9] Docs: send-email's usage text and man page mention same options Michael Witten
2008-09-30 12:58 ` [PATCH 2/9] Docs: send-email usage text much sexier Michael Witten
2008-09-30 12:58 ` [PATCH 3/9] Docs: send-email: Man page option ordering Michael Witten
2008-09-30 12:58 ` [PATCH 4/9] send-email: change --no-validate to boolean --[no-]validate Michael Witten
2008-09-30 12:58 ` [PATCH 5/9] Docs: send-email: --chain_reply_to -> --[no-]chain-reply-to Michael Witten
2008-09-30 12:58 ` [PATCH 6/9] Docs: send-email: Remove unnecessary config variable description Michael Witten
2008-09-30 12:58 ` [PATCH 7/9] Docs: send-email: Create logical groupings for --help text Michael Witten
2008-09-30 12:58 ` [PATCH 8/9] Docs: send-email: Create logical groupings for man text Michael Witten
2008-09-30 12:58 ` [PATCH 9/9] send-email: signedoffcc -> signedoffbycc, but handle both Michael Witten
2008-10-01 3:27 ` [PATCH 3/9] Docs: send-email: Man page option ordering Jeff King
2008-10-01 20:34 ` Michael Witten
2008-10-01 20:36 ` Shawn O. Pearce
2008-09-28 5:08 ` [PATCH 1/8] Docs: send-email's usage text and man page mention same options Miklos Vajna
2008-09-28 19:04 ` Michael Witten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1222710066-57768-2-git-send-email-mfwitten@mit.edu \
--to=mfwitten@mit.edu \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.