All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	Tomas Winkler <tomasw@gmail.com>
Subject: Re: [PATCH v2] iwlwifi: fix DMA code and bugs
Date: Mon, 06 Oct 2008 18:42:39 +0200	[thread overview]
Message-ID: <1223311359.11272.212.camel@violet.holtmann.net> (raw)
In-Reply-To: <1223309405.15196.32.camel@johannes.berg>

Hi John,

> This patch cleans up the DMA code to be understandable and not
> completely wrong. In particular:
>  * there is no need to have a weird iwl_tfd_frame_data struct that is
>    used 10 times, just use an address struct 20 times
>  * therefore, all the is_odd junk goes away
>  * fix a bug in iwl_hcmd_queue_reclaim where it would reclaim all the
>    fragments of a descriptor rather than all descriptors (this may be
>    the cause of the dma unmapping problem I reported)
>  * some more cleanups
> 
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> ---
> Tested on 5000 hw, please apply.
> 
> v2: fixes small issue with getting rid of iwl_get_dma_hi_address.

if this fixes the crashes with my 4965 card in my X61, then this is a
candidate for 2.6.27-rc8. I will built a new kernel for my X61 as soon
as possible.

Regards

Marcel



  reply	other threads:[~2008-10-06 16:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-06 16:00 [PATCH] iwlwifi: fix DMA code and bugs Johannes Berg
2008-10-06 16:10 ` [PATCH v2] " Johannes Berg
2008-10-06 16:42   ` Marcel Holtmann [this message]
2008-10-06 16:47     ` Johannes Berg
2008-10-06 17:20     ` Johannes Berg
2008-10-06 16:49   ` Tomas Winkler
2008-10-06 16:51     ` Johannes Berg
2008-10-06 16:54       ` Johannes Berg
2008-10-06 18:30         ` Tomas Winkler
2008-10-06 18:34           ` Johannes Berg
2008-10-06 19:23           ` John W. Linville
2008-10-06 19:52             ` Johannes Berg
2008-10-06 21:37             ` Tomas Winkler
2008-10-14 15:21   ` Johannes Berg
2008-10-14 15:42     ` reinette chatre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1223311359.11272.212.camel@violet.holtmann.net \
    --to=marcel@holtmann.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=tomasw@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.