From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: [PATCH 8/8] ASoC: Make WM8510 microphone input a DAPM mixer
Date: Wed, 8 Oct 2008 10:38:00 +0100 [thread overview]
Message-ID: <1223458680-9506-8-git-send-email-broonie@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1223458680-9506-7-git-send-email-broonie@opensource.wolfsonmicro.com>
The WM8510 microphone input PGA was represented as a DAPM PGA but in
DAPM terms the functionality is that of a mixer since it takes three
switchable inputs and produces one output. Representing it as an input
was causing its controls to be misinterpreted as gain controls and
would cause some required DAPM updates to be missed.
Reported-by: Jukka Hynninen <ext-jukka.hynninen@vaisala.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
sound/soc/codecs/wm8510.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/codecs/wm8510.c b/sound/soc/codecs/wm8510.c
index 94cab49..ea524c4 100644
--- a/sound/soc/codecs/wm8510.c
+++ b/sound/soc/codecs/wm8510.c
@@ -227,9 +227,9 @@ SND_SOC_DAPM_PGA("SpkN Out", WM8510_POWER3, 5, 0, NULL, 0),
SND_SOC_DAPM_PGA("SpkP Out", WM8510_POWER3, 6, 0, NULL, 0),
SND_SOC_DAPM_PGA("Mono Out", WM8510_POWER3, 7, 0, NULL, 0),
-SND_SOC_DAPM_PGA("Mic PGA", WM8510_POWER2, 2, 0,
- &wm8510_micpga_controls[0],
- ARRAY_SIZE(wm8510_micpga_controls)),
+SND_SOC_DAPM_MIXER("Mic PGA", WM8510_POWER2, 2, 0,
+ &wm8510_micpga_controls[0],
+ ARRAY_SIZE(wm8510_micpga_controls)),
SND_SOC_DAPM_MIXER("Boost Mixer", WM8510_POWER2, 4, 0,
&wm8510_boost_controls[0],
ARRAY_SIZE(wm8510_boost_controls)),
--
1.5.6.5
next prev parent reply other threads:[~2008-10-08 9:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-08 9:36 [PATCH 0/8] ASoC updates Mark Brown
2008-10-08 9:37 ` [PATCH 1/8] ASoC: Add custom SOC_SINGLE_TLV for tlv320aic23 codec Mark Brown
2008-10-08 9:37 ` [PATCH 2/8] ASoC: Add WM8753 SPI support Mark Brown
2008-10-08 9:37 ` [PATCH 3/8] ASoC: Add WM8510 " Mark Brown
2008-10-08 9:37 ` [PATCH 4/8] ALSA: ASoC: add new param mux to dapm_mux_update_power Mark Brown
2008-10-08 9:37 ` [PATCH 5/8] ASoC: tlv320aic3x: Use uniform tlv320aic naming Mark Brown
2008-10-08 9:37 ` [PATCH 6/8] ASoC: Remove unused AUDIO_NAME define from codec drivers Mark Brown
2008-10-08 9:37 ` [PATCH 7/8] ASoC: Implement WM8510 bias level control Mark Brown
2008-10-08 9:38 ` Mark Brown [this message]
2008-10-08 9:49 ` [PATCH 0/8] ASoC updates Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1223458680-9506-8-git-send-email-broonie@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.