Re: [PATCH 10/15] RPC/RDMA: return a consistent error to mount, when connect fails.

[Trond Myklebust <trond.myklebust@fys.uio.no>]

On Wed, 2008-10-08 at 11:48 -0400, Tom Talpey wrote:
> The mount system call path does not expect such errors as ECONNREFUSED
> to be returned from failed transport connection attempts, otherwise it
> prints simply "internal error". Translate all such errors to ENOTCONN
> from RPC/RDMA to match sockets behavior.

Hmm... Shouldn't we be passing the ECONNREFUSED error here, and rather
fix the downstream error paths?

> Signed-off-by: Tom Talpey <talpey@netapp.com>
> ---
> 
>  net/sunrpc/xprtrdma/rpc_rdma.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/sunrpc/xprtrdma/rpc_rdma.c b/net/sunrpc/xprtrdma/rpc_rdma.c
> index c4b8011..11ea8da 100644
> --- a/net/sunrpc/xprtrdma/rpc_rdma.c
> +++ b/net/sunrpc/xprtrdma/rpc_rdma.c
> @@ -700,7 +700,7 @@ rpcrdma_conn_func(struct rpcrdma_ep *ep)
>  			xprt_wake_pending_tasks(xprt, 0);
>  	} else {
>  		if (xprt_test_and_clear_connected(xprt))
> -			xprt_wake_pending_tasks(xprt, ep->rep_connected);
> +			xprt_wake_pending_tasks(xprt, -ENOTCONN);
>  	}
>  	spin_unlock_bh(&xprt->transport_lock);
>  }
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html