From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Kevin Diggs <kevdig@hypersurf.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: 8600 serial support
Date: Thu, 09 Oct 2008 07:45:11 +1100 [thread overview]
Message-ID: <1223498711.8157.90.camel@pasglop> (raw)
In-Reply-To: <48ED0F30.7080103@hypersurf.com>
On Wed, 2008-10-08 at 12:51 -0700, Kevin Diggs wrote:
> Hi,
>
> I thought I might take a whack at fixing the 2.6 serial driver
> for my 8600. At the top of pmac_zilog.c (2.6.26) there is a todo for DMA.
> A quick glance at macserial.c (2.4.31) suggests it has dbdma support for
> receive. Anyone know of any pitfalls for adding dbdma support for
> pmac_zilog.c?
Yes, it's not totally trivial and I wouldn't recommend using the weirdo
code in macserial (it does things that I don't understand how they work
with the dbdma engine).
The best way I see is to start from scratch with two different
mechanisms:
- For Tx, that's the easiest, the fire off DMA's for outgoing chars,
maybe queue up a few descriptors to let data accumulate.
- For Rx, one descriptor per byte. That sucks but I think that's also
what Apple does. No need to have a huge Rx buffer anyway. That gives you
precise Rx status to the byte.
Ben.
next prev parent reply other threads:[~2008-10-08 20:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-08 19:51 8600 serial support Kevin Diggs
2008-10-08 20:45 ` Benjamin Herrenschmidt [this message]
2008-10-08 23:50 ` Brad Boyer
2008-10-09 1:40 ` Kevin Diggs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1223498711.8157.90.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=kevdig@hypersurf.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.