From: Eric Paris <eparis@redhat.com>
To: kkeil@suse.de
Cc: isdn4linux@listserv.isdn4linux.de, linux-kernel@vger.kernel.org,
davem@davemloft.net
Subject: mISDN didn't define af_family_key_strings et al.
Date: Wed, 08 Oct 2008 20:27:29 -0400 [thread overview]
Message-ID: <1223512049.2952.8.camel@localhost.localdomain> (raw)
I see that recently AF_ISDN was added to the kernel but I don't see them
having updated af_family_key_strings[] found in net/core/sock.c. I'm
adding a new one myself and caught a NULL entry toward the end of the
array. My assumption is that isdn is using the sk_lock-AF_MAX entry
instead of their own.
As an aside it was nice having such a clean explosion when I didn't add
my own. Are the AF_MAX entries in those arrays really needed? If we
dropped it altogether would others (like myself and the isdn people) who
forgot to add their own get nice explosions with no other problems?
-Eric
next reply other threads:[~2008-10-09 0:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-09 0:27 Eric Paris [this message]
2008-10-09 0:28 ` mISDN didn't define af_family_key_strings et al David Miller
2008-10-09 0:57 ` Eric Paris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1223512049.2952.8.camel@localhost.localdomain \
--to=eparis@redhat.com \
--cc=davem@davemloft.net \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=kkeil@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.