From: Matt Mackall <mpm@selenic.com>
To: "Moore, Robert" <robert.moore@intel.com>
Cc: Len Brown <lenb@kernel.org>, Pavel Machek <pavel@suse.cz>,
Ingo Molnar <mingo@elte.hu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: RE: [PATCH] x86: trim ACPI sleep stack buffer
Date: Thu, 09 Oct 2008 12:41:50 -0500 [thread overview]
Message-ID: <1223574110.17706.109.camel@calx> (raw)
In-Reply-To: <4911F71203A09E4D9981D27F9D83085803123361@orsmsx503.amr.corp.intel.com>
On Thu, 2008-10-09 at 10:23 -0700, Moore, Robert wrote:
> Sounds like you need a
>
> #define DEFAULT_STACK_SIZE 4096
>
> Somewhere.
Or maybe something like this:
x86: remove magic number from ACPI sleep stack buffer
Signed-off-by: Matt Mackall <mpm@selenic.com>
diff -r 375a00b8bf10 arch/x86/kernel/acpi/sleep.c
--- a/arch/x86/kernel/acpi/sleep.c Thu Oct 09 12:38:55 2008 -0500
+++ b/arch/x86/kernel/acpi/sleep.c Thu Oct 09 12:40:10 2008 -0500
@@ -97,7 +97,7 @@
#else /* CONFIG_64BIT */
header->trampoline_segment = setup_trampoline() >> 4;
#ifdef CONFIG_SMP
- stack_start.sp = temp_stack + 4096;
+ stack_start.sp = temp_stack + sizeof(temp_stack);
#endif
initial_code = (unsigned long)wakeup_long64;
saved_magic = 0x123456789abcdef0;
--
Mathematics is the supreme nostalgia of our time.
next prev parent reply other threads:[~2008-10-09 17:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-01 0:12 Why is arch/x86/kernel/acpi/sleep.c:temp_stack 10k? Matt Mackall
2008-10-09 8:56 ` Pavel Machek
2008-10-09 16:56 ` [PATCH] x86: trim ACPI sleep stack buffer Matt Mackall
2008-10-09 17:19 ` Len Brown
2008-10-09 17:23 ` Moore, Robert
2008-10-09 17:41 ` Matt Mackall [this message]
2008-10-09 18:07 ` Pavel Machek
2008-10-09 18:35 ` Len Brown
2008-10-09 21:25 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1223574110.17706.109.camel@calx \
--to=mpm@selenic.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pavel@suse.cz \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.