From: David Woodhouse <dwmw2@infradead.org>
To: Christian Parpart <trapni@gentoo.org>
Cc: Eric Anopolsky <erpo41@gmail.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-progs: autotoolized and splitup into {libbtrfs,tools,tests}
Date: Fri, 10 Oct 2008 07:38:30 +0100 [thread overview]
Message-ID: <1223620710.28324.95.camel@macbook.infradead.org> (raw)
In-Reply-To: <200810100301.52995.trapni@gentoo.org>
On Fri, 2008-10-10 at 03:01 +0200, Christian Parpart wrote:
> whether btrfs to be using autotools or not, the other kind this patch
> addressed seems to be more important to me: project modularization.
That makes a certain amount of sense, but should definitely be submitted
as a separate patch. And it would probably be best to generate it with
'git-diff -M' so that renamed files are shown as such. rather than
deletion and addition. That'll make your patch far more reviewable.
I'm still not convinced that third party code should be linking against
a libbtrfs just yet, but that doesn't mean it shouldn't be set up to
allow that to happen in future.
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
prev parent reply other threads:[~2008-10-10 6:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-09 2:20 [PATCH] btrfs-progs: autotoolized and splitup into {libbtrfs,tools,tests} Christian Parpart
2008-10-09 5:55 ` Christoph Hellwig
2008-10-09 6:47 ` Christian Parpart
2008-10-09 10:45 ` David Woodhouse
2008-10-09 13:55 ` Christian Parpart
2008-10-09 21:52 ` Eric Anopolsky
2008-10-09 22:07 ` David Woodhouse
2008-10-10 1:01 ` Christian Parpart
2008-10-10 6:38 ` David Woodhouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1223620710.28324.95.camel@macbook.infradead.org \
--to=dwmw2@infradead.org \
--cc=erpo41@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=trapni@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.