From: Pavel Roskin <proski@gnu.org>
To: Christian Lamparter <chunkeey@web.de>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Larry Finger <Larry.Finger@lwfinger.net>,
wireless <linux-wireless@vger.kernel.org>
Subject: Re: [RFC/RFT] p54: Fix for big-endian architecture
Date: Mon, 13 Oct 2008 18:55:26 -0400 [thread overview]
Message-ID: <1223938526.27118.6.camel@dv> (raw)
In-Reply-To: <200810140055.34065.chunkeey@web.de>
On Tue, 2008-10-14 at 00:55 +0200, Christian Lamparter wrote:
> > I don't get that on i386. But the values don't seem to be corrupted
> by
> > byte-swapping.
> >
> Hmm, this should be impossible since:
> "p54: report appropriate rate and band values for 802.11a"
> 5f840304b5f7dff0028407fa9b284aecb85a94aa
I see. It's recent code, so maybe it wasn't broken yet when I was
testing it on i386.
This code in drivers/net/wireless/p54/p54common.c sets rate_idx:
rx_status.rate_idx = (dev->conf.channel->band == IEEE80211_BAND_2GHZ ?
hdr->rate : (hdr->rate - 4)) & 0xf;
printk() shows:
dev->conf.channel->band = 1, hdr->rate = 0, rx_status.rate_idx = 12
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2008-10-13 22:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-09 15:19 [RFC/RFT] p54: Fix for big-endian architecture Larry Finger
2008-10-09 16:58 ` Christian Lamparter
2008-10-10 0:39 ` Larry Finger
2008-10-10 1:29 ` Christian Lamparter
2008-10-13 21:44 ` Pavel Roskin
2008-10-13 22:24 ` Johannes Berg
2008-10-13 22:36 ` Pavel Roskin
2008-10-13 22:55 ` Christian Lamparter
2008-10-13 22:55 ` Pavel Roskin [this message]
2008-10-13 23:05 ` Pavel Roskin
2008-10-13 23:07 ` Johannes Berg
2008-10-13 23:36 ` Pavel Roskin
2008-10-14 0:00 ` Pavel Roskin
2008-10-14 0:15 ` Christian Lamparter
2008-10-14 1:20 ` Pavel Roskin
2008-10-14 2:10 ` Christian Lamparter
2008-10-14 2:42 ` [RFC/RFT][PATCH] p54: enable 2.4/5GHz spectrum by eeprom bits Christian Lamparter
2008-10-14 8:15 ` [RFC/RFT] p54: Fix for big-endian architecture Johannes Berg
2008-10-13 23:31 ` Christian Lamparter
2008-10-13 23:36 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1223938526.27118.6.camel@dv \
--to=proski@gnu.org \
--cc=Larry.Finger@lwfinger.net \
--cc=chunkeey@web.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.