From: Matt Draisey <matt@draisey.ca>
To: git@vger.kernel.org
Subject: Detached checkout will clobber branch head when using symlink HEAD
Date: Wed, 15 Oct 2008 14:24:47 -0400 [thread overview]
Message-ID: <1224095087.5366.19.camel@localhost> (raw)
The faulty code appears to be this
git 1.6.0.2.526.g5c283
builtin-checkout.c
> 481 static void update_refs_for_switch(struct checkout_opts *opts,
> 500 if (new->path) {
>
> 511 } else if (strcmp(new->name, "HEAD")) {
> 512 update_ref(msg.buf, "HEAD", new->commit->object.sha1, NULL,
> 513 REF_NODEREF, DIE_ON_ERR);
> 514 if (!opts->quiet) {
> 515 if (old->path)
> 516 fprintf(stderr, "Note: moving to \"%s\" which isn't a local branch\nIf you want to create a new branch from this checkout, you may do so\n(now or later) by using -b with the checkout command again. Example:\n git checkout -b <new_branch_name>\n", new->name);
> 517 describe_detached_head("HEAD is now at", new->commit);
> 518 }
> 519 }
If HEAD is a symlink rather than a "ref:" style link this is really bad.
next reply other threads:[~2008-10-15 18:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-15 18:24 Matt Draisey [this message]
2008-10-16 19:17 ` Detached checkout will clobber branch head when using symlink HEAD Jeff King
2008-10-16 20:11 ` Matt Draisey
2008-10-16 20:20 ` Nicolas Pitre
2008-10-16 20:22 ` Jeff King
2008-10-16 20:30 ` Nicolas Pitre
2008-10-16 20:28 ` Matt Draisey
2008-10-16 20:47 ` Nicolas Pitre
2008-10-16 20:39 ` Jeff King
2008-10-17 23:08 ` Junio C Hamano
2008-10-17 23:10 ` [PATCH 1/3] demonstrate breakage of detached checkout with symbolic link HEAD Junio C Hamano
2008-10-17 23:10 ` [PATCH 2/3] Enhance hold_lock_file_for_{update,append}() API Junio C Hamano
2008-10-17 23:11 ` [PATCH 3/3] Fix checkout not to clobber the branch when using symlinked HEAD upon detaching Junio C Hamano
2008-10-19 13:00 ` Detached checkout will clobber branch head when using symlink HEAD Jeff King
2008-10-19 19:36 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1224095087.5366.19.camel@localhost \
--to=matt@draisey.ca \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.