Re: [PATCH 1/1] edac cell: fix incorrect edac_mode

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

On Thu, 2008-10-16 at 16:35 -0700, Andrew Morton wrote:
> Well that sounds a bit wrong of it.
> 
> > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > Signed-off-by: Doug Thompson <dougthompson@xmission.com>
> > ---
> > 
> >  drivers/edac/cell_edac.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > --- linux-work.orig/drivers/edac/cell_edac.c  2008-10-15
> 15:35:21.000000000 +1100
> > +++ linux-work/drivers/edac/cell_edac.c       2008-10-15
> 15:35:29.000000000 +1100
> > @@ -142,7 +142,7 @@ static void __devinit cell_edac_init_csr
> >               csrow->nr_pages = (r.end - r.start + 1) >> PAGE_SHIFT;
> >               csrow->last_page = csrow->first_page + csrow->nr_pages
> - 1;
> >               csrow->mtype = MEM_XDR;
> > -             csrow->edac_mode = EDAC_FLAG_EC | EDAC_FLAG_SECDED;
> > +             csrow->edac_mode = EDAC_SECDED;
> >               dev_dbg(mci->dev,
> >                       "Initialized on node %d, chanmask=0x%x,"
> >                       " first_page=0x%lx, nr_pages=0x%x\n",
> 
> Seems to be needed in 2.6.27.x?  Applies OK to 2.6.26, 2.6.25, etc.
> 
> How far back shold we port this?

.25 sounds fine.

Cheers,
Ben.