From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Brian King <brking@linux.vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
Milton Miller <miltonm@bga.com>
Subject: Re: [PATCHv2 1/1] powerpc: Update page in counter for CMM
Date: Wed, 22 Oct 2008 11:11:31 +1100 [thread overview]
Message-ID: <1224634291.7654.287.camel@pasglop> (raw)
In-Reply-To: <48FE3B16.5050402@linux.vnet.ibm.com>
> - if (ret & VM_FAULT_MAJOR)
> + if (ret & VM_FAULT_MAJOR) {
> current->maj_flt++;
> - else
> + preempt_disable();
> + get_lppaca()->page_ins++;
> + preempt_enable();
> + } else
That isn't going to work very well on 32-bit or non-pseries
platforms :-)
We need either something like a ppc_md. callback or at least a test for
firmware feature... (which probably still needs an ifdef to build on
32 bit).
Cheers,
Ben.
next prev parent reply other threads:[~2008-10-22 0:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-20 22:19 [PATCH 1/1] powerpc: Update page in counter for CMM Brian King
2008-10-21 4:36 ` [1/1] " Milton Miller
2008-10-21 20:24 ` Brian King
2008-10-21 20:27 ` [PATCHv2 1/1] " Brian King
2008-10-22 0:11 ` Benjamin Herrenschmidt [this message]
2008-10-22 15:53 ` [PATCHv3 " Brian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1224634291.7654.287.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=brking@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=miltonm@bga.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.