All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Mike Ditto <mditto@consentry.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: Add del_node function to allow early boot code to prune inapplicable devices.
Date: Wed, 22 Oct 2008 11:23:29 +1100	[thread overview]
Message-ID: <1224635009.7654.290.camel@pasglop> (raw)
In-Reply-To: <20081021233306.GA2108@secretlab.ca>

On Tue, 2008-10-21 at 17:33 -0600, Grant Likely wrote:
> On Tue, Oct 21, 2008 at 02:32:29PM -0700, Mike Ditto wrote:
> > Reposting in proper format...
> > 
> > Some platforms have variants that can share most of a flat device tree but need
> > a few devices selectively pruned at boot time.  This adds del_node() to ops.h
> > to allow access to the existing fdt_del_node().
> > 
> > Signed-off-by: Mike Ditto <mditto@consentry.com>
> 
> Looks good to me.
> 
> Acked-by: Grant Likely <grant.likely@secretlab.ca>

little nit: The patch doesn't quite have the right form.

Patches to the kernel are expected to apply with -p1, so
for example, the patch line contains:

arch/powerpc/boot/ops.h

It should be

something/arch/powerpc/boot/ops.h

I've fixed it up manually so no need to re-submit, but you'll know next
time :-)

Cheers,
Ben.

  reply	other threads:[~2008-10-22  0:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-17  0:52 device tree variations Mike Ditto
2008-10-17  1:26 ` David Gibson
2008-10-18  2:14   ` Mike Ditto
2008-10-21  1:49     ` David Gibson
2008-10-21  6:00     ` Benjamin Herrenschmidt
2008-10-21 21:32   ` [PATCH] powerpc: Add del_node function to allow early boot code to prune inapplicable devices Mike Ditto
2008-10-21 23:33     ` Grant Likely
2008-10-22  0:23       ` Benjamin Herrenschmidt [this message]
2008-10-22  0:25         ` Mike Ditto
2008-10-22  0:09     ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1224635009.7654.290.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mditto@consentry.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.