All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark McLoughlin <markmc@redhat.com>
To: Avi Kivity <avi@qumranet.com>
Cc: kvm@vger.kernel.org, Mark McLoughlin <markmc@redhat.com>,
	Anthony Liguori <aliguori@us.ibm.com>
Subject: [PATCH 2/3] virtio_net: Make use of napi_weight module param
Date: Wed, 22 Oct 2008 16:20:29 +0100	[thread overview]
Message-ID: <1224688830-26216-3-git-send-email-markmc@redhat.com> (raw)
In-Reply-To: <1224688830-26216-2-git-send-email-markmc@redhat.com>

Currently, the napi_weight module param is ignored and
we hardcode the weight to 16 since this commit:

    commit 85a8b9da078977c6198d434837c7d077669c9c54
    Author: Anthony Liguori <aliguori@us.ibm.com>
    Date:   Sun Jan 6 21:37:01 2008 -0600

      Make sure to set weight to 16 always.

      Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

Allowing the weight to be higher should reduce the interrupt
rate in the guest. In practice, though, it doesn't appear to
make much difference.

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>
---
 external-module-compat.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/external-module-compat.h b/external-module-compat.h
index 4da2296..fc20bc9 100644
--- a/external-module-compat.h
+++ b/external-module-compat.h
@@ -65,7 +65,7 @@ struct napi_struct {
 #define netif_napi_add(dev, napi, pollfn, weightval)	\
 do {							\
 	(dev)->poll = (pollfn);				\
-	(dev)->weight = 16;				\
+	(dev)->weight = (weightval);                    \
 } while(0)
 #define netif_rx_schedule(dev, napi) netif_rx_schedule(dev)
 
-- 
1.5.5.1


  reply	other threads:[~2008-10-22 15:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-22 15:20 [PATCH 0/3] Some kvm-guest-drivers-linux/virtio_net fixes Mark McLoughlin
2008-10-22 15:20 ` [PATCH 1/3] virtio_net: Fix leaked netdev->refcnt Mark McLoughlin
2008-10-22 15:20   ` Mark McLoughlin [this message]
2008-10-22 15:20     ` [PATCH 3/3] virtio_net: support ethtool offload queries Mark McLoughlin
2008-10-26 14:17   ` [PATCH 1/3] virtio_net: Fix leaked netdev->refcnt Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1224688830-26216-3-git-send-email-markmc@redhat.com \
    --to=markmc@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=avi@qumranet.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.