All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nigel Cunningham <ncunningham@crca.org.au>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	pm list <linux-pm@lists.linux-foundation.org>,
	Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 1/4] Hibernate: Call platform_begin before	swsusp_shrink_memory
Date: Thu, 23 Oct 2008 09:37:52 +1100	[thread overview]
Message-ID: <1224715072.8156.4.camel@nigel-laptop> (raw)
In-Reply-To: <200810222250.36537.rjw@sisk.pl>

Hi.

On Wed, 2008-10-22 at 22:50 +0200, Rafael J. Wysocki wrote:
> From: Zhang Rui <rui.zhang@intel.com>
> 
> Hibernate: Call platform_begin before swsusp_shrink_memory
> 
> Call platform_begin() before swsusp_shrink_memory() so that we can
> always allocate enough memory to save the ACPI NVS region from
> platform_begin().
> 
> Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> ---
>  kernel/power/disk.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> Index: linux-2.6/kernel/power/disk.c
> ===================================================================
> --- linux-2.6.orig/kernel/power/disk.c
> +++ linux-2.6/kernel/power/disk.c
> @@ -267,12 +267,12 @@ int hibernation_snapshot(int platform_mo
>  {
>  	int error, ftrace_save;
>  
> -	/* Free memory before shutting down devices. */
> -	error = swsusp_shrink_memory();
> +	error = platform_begin(platform_mode);
>  	if (error)
>  		return error;
>  
> -	error = platform_begin(platform_mode);
> +	/* Free memory before shutting down devices. */
> +	error = swsusp_shrink_memory();
>  	if (error)
>  		goto Close;
>  

Acked-by: Nigel Cunningham <nigel@tuxonice.net>

  reply	other threads:[~2008-10-22 22:37 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-22 20:49 [PATCH 0/4] Hibernate: Handle ACPI NVS memory as required by the spec Rafael J. Wysocki
2008-10-22 20:50 ` [PATCH 1/4] Hibernate: Call platform_begin before swsusp_shrink_memory Rafael J. Wysocki
2008-10-22 22:37   ` Nigel Cunningham [this message]
2008-10-26 12:00   ` Pavel Machek
2008-10-26 12:00   ` [linux-pm] " Pavel Machek
2008-10-22 20:50 ` Rafael J. Wysocki
2008-10-22 20:52 ` [PATCH 2/4] ACPI hibernate: Add a mechanism to save/restore ACPI NVS memory Rafael J. Wysocki
2008-10-22 20:52 ` Rafael J. Wysocki
2008-10-22 22:48   ` [linux-pm] " Nigel Cunningham
2008-10-22 23:08     ` Rafael J. Wysocki
2008-10-22 23:08     ` [linux-pm] " Rafael J. Wysocki
2008-10-23  1:37       ` Nigel Cunningham
2008-10-23  1:37       ` [linux-pm] " Nigel Cunningham
2008-10-23  5:47         ` [PATCH 2/4] ACPI hibernate: Add a mechanism to save/restore ACPI NVS memory (rev. 2) Rafael J. Wysocki
2008-10-23  8:03           ` Nigel Cunningham
2008-10-23  8:03           ` Nigel Cunningham
2008-10-23  5:47         ` Rafael J. Wysocki
2008-10-22 22:48   ` [PATCH 2/4] ACPI hibernate: Add a mechanism to save/restore ACPI NVS memory Nigel Cunningham
2008-10-26 12:08   ` [linux-pm] " Pavel Machek
2008-10-26 12:23     ` Rafael J. Wysocki
2008-11-18 16:14       ` Pavel Machek
2008-11-18 16:14       ` [linux-pm] " Pavel Machek
2008-10-26 12:23     ` Rafael J. Wysocki
2008-10-26 12:08   ` Pavel Machek
2008-10-22 20:53 ` [PATCH 3/4] x86 hibernate: Mark ACPI NVS memory region at startup Rafael J. Wysocki
2008-10-22 20:53 ` Rafael J. Wysocki
2008-10-26 12:14   ` [linux-pm] " Pavel Machek
2008-10-26 12:29     ` Rafael J. Wysocki
2008-10-29  9:21       ` Zhang Rui
2008-10-29 11:18         ` Pavel Machek
2008-10-29 11:18         ` [linux-pm] " Pavel Machek
2008-10-30 23:59           ` Rafael J. Wysocki
2008-10-30 23:59           ` [linux-pm] " Rafael J. Wysocki
2008-10-29  9:21       ` Zhang Rui
2008-10-26 12:29     ` Rafael J. Wysocki
2008-10-26 12:14   ` Pavel Machek
2008-10-22 20:54 ` [PATCH 4/4] ACPI hibernate: Introduce new kernel parameter acpi_sleep=s4_nonvs Rafael J. Wysocki
2008-10-22 20:54 ` Rafael J. Wysocki
2008-10-22 22:51   ` [linux-pm] " Nigel Cunningham
2008-10-22 23:10     ` Rafael J. Wysocki
2008-10-22 23:10     ` [linux-pm] " Rafael J. Wysocki
2008-10-22 23:19       ` [PATCH 4/4] ACPI hibernate: Introduce new kernel parameter acpi_sleep=s4_nonvs (rev. 2) Rafael J. Wysocki
2008-10-26 12:18         ` Pavel Machek
2008-10-26 12:18         ` [linux-pm] " Pavel Machek
2008-10-22 23:19       ` Rafael J. Wysocki
2008-10-22 22:51   ` [PATCH 4/4] ACPI hibernate: Introduce new kernel parameter acpi_sleep=s4_nonvs Nigel Cunningham
  -- strict thread matches above, loose matches on Subject: below --
2008-10-26 19:48 [PATCH 0/4] Hibernate: Handle ACPI NVS memory as required by the spec (rev. 2) Rafael J. Wysocki
2008-10-26 19:50 ` [PATCH 1/4] Hibernate: Call platform_begin before swsusp_shrink_memory Rafael J. Wysocki
2008-10-26 19:50 ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1224715072.8156.4.camel@nigel-laptop \
    --to=ncunningham@crca.org.au \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=mingo@elte.hu \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.