From: Matt Mackall <mpm@selenic.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: akpm <akpm@linuxfoundation.org>
Subject: Re: Bloatwatch 2.6.28-rc1: last_sysfs_file
Date: Fri, 24 Oct 2008 16:15:23 -0500 [thread overview]
Message-ID: <1224882923.3248.51.camel@calx> (raw)
In-Reply-To: <1224881514.3248.46.camel@calx>
On Fri, 2008-10-24 at 15:52 -0500, Matt Mackall wrote:
> 2.6.28-rc1 adds 4k for last_sysfs_file debug tracking. That's one hell
> of a long sysfs path.
>
> http://www.selenic.com/bloatwatch/?cmd=compare;v1=2.6.27;v2=2.6.28-rc1;part=/built-in/fs/sysfs
..especially given that printk is limited to 1k at a time.
sysfs: shrink last_sysfs_file to a reasonable size
sysfs was reserving 4k to store filenames for debug despite printk being
limited to 1k. Shrink this to something more reasonable.
Signed-off-by: Matt Mackall <mpm@selenic.com>
diff -r ac8c82ff3be7 fs/sysfs/file.c
--- a/fs/sysfs/file.c Fri Oct 24 13:13:04 2008 -0500
+++ b/fs/sysfs/file.c Fri Oct 24 16:11:53 2008 -0500
@@ -25,7 +25,7 @@
#include "sysfs.h"
/* used in crash dumps to help with debugging */
-static char last_sysfs_file[PATH_MAX];
+static char last_sysfs_file[200]; /* allow for disgustingly long paths */
void sysfs_printk_last_file(void)
{
printk(KERN_EMERG "last sysfs file: %s\n", last_sysfs_file);
--
Mathematics is the supreme nostalgia of our time.
next prev parent reply other threads:[~2008-10-24 21:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-24 20:51 Bloatwatch 2.6.28-rc1: last_sysfs_file Matt Mackall
2008-10-24 21:15 ` Matt Mackall [this message]
2008-10-25 10:38 ` Chris Snook
2008-10-27 16:11 ` Matt Mackall
2008-10-27 16:50 ` Chris Snook
2008-10-27 17:46 ` Matt Mackall
2008-10-27 18:16 ` Chris Snook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1224882923.3248.51.camel@calx \
--to=mpm@selenic.com \
--cc=akpm@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.