From: Harvey Harrison <harvey.harrison@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: David Miller <davem@davemloft.net>,
anders@anduras.de, netdev@vger.kernel.org
Subject: Re: [PATCH] add %pM printf format specifier
Date: Sun, 26 Oct 2008 12:01:14 -0700 [thread overview]
Message-ID: <1225047674.10060.10.camel@brick> (raw)
In-Reply-To: <1225009822.3478.30.camel@johannes.berg>
On Sun, 2008-10-26 at 09:30 +0100, Johannes Berg wrote:
> static char *ip6_string(char *buf, char *end, be16 *addr, int field_width, int precision, int flags)
> {
> char ip6[8*5];
> char *p = ip6;
> int i;
> u16 tmp;
>
> for (i=0; i<7; i++) {
> tmp = cpu_to_le16(addr[i]);
tmp = be16_to_cpup(addr + i);
> p = pack_hex_byte(p, tmp >> 8);
> p = pack_hex_byte(p, tmp & 0xFF);
> if (!(flags & SPECIAL))
> *p++ = ':';
> }
> tmp = cpu_to_le16(addr[7]);
tmp = be16_to_cpup(addr + 7);
Or maybe just cast addr to char * and avoid the byteswapping altogether.
Just a thought,
Harvey
next prev parent reply other threads:[~2008-10-26 19:01 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-24 23:46 [PATCH] add %pM printf format specifier Johannes Berg
2008-10-25 1:41 ` Joe Perches
2008-10-25 8:00 ` Johannes Berg
2008-10-25 17:44 ` Sven Anders
2008-10-26 8:01 ` Johannes Berg
2008-10-26 8:03 ` David Miller
2008-10-26 8:21 ` Johannes Berg
2008-10-26 8:30 ` Johannes Berg
2008-10-26 19:01 ` Harvey Harrison [this message]
2008-10-26 19:33 ` Johannes Berg
2008-10-26 19:38 ` Harvey Harrison
2008-10-26 19:40 ` Johannes Berg
2008-10-26 22:39 ` [RFC PATCH] printk: add the %pM, %p4, %p6 format specifiers Harvey Harrison
2008-10-27 0:31 ` [RFC PATCHv2] " Harvey Harrison
2008-10-27 1:21 ` Frans Pop
2008-10-27 2:08 ` H. Peter Anvin
2008-10-27 6:59 ` Johannes Berg
2008-10-27 16:28 ` Harvey Harrison
2008-10-27 19:38 ` David Miller
2008-10-27 19:47 ` Johannes Berg
2008-10-27 19:59 ` [RFC PATCHv3] printk: add %pM format specifier for MAC addresses Harvey Harrison
2008-10-27 21:55 ` Joe Perches
2008-10-27 22:46 ` David Miller
2008-10-27 22:47 ` David Miller
2008-10-27 23:14 ` Harvey Harrison
2008-10-27 23:31 ` Alexey Dobriyan
2008-10-27 23:48 ` Joe Perches
2008-10-28 8:04 ` Johannes Berg
2008-10-27 23:55 ` David Miller
2008-10-28 0:05 ` Harvey Harrison
2008-10-28 0:22 ` Joe Perches
2008-10-28 8:06 ` Johannes Berg
2008-10-26 8:38 ` [PATCH] add %pM printf format specifier Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1225047674.10060.10.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=anders@anduras.de \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.