From: Harvey Harrison <harvey.harrison@gmail.com>
To: djwong@us.ibm.com
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ibmpex: trivial endian annotation in extract_data helper
Date: Mon, 27 Oct 2008 12:26:06 -0700 [thread overview]
Message-ID: <1225135566.5396.1.camel@brick> (raw)
In-Reply-To: <20081027183209.GU7771@tree.beaverton.ibm.com>
On Mon, 2008-10-27 at 11:32 -0700, Darrick J. Wong wrote:
> On Fri, Oct 24, 2008 at 04:44:58PM -0700, Harvey Harrison wrote:
> > This helper is used in few enough locations that open-coding it
> > at the call sites may be better than the helper.
>
> I'm not sure how this comment relates to the diff.
>
I was referring to the extract_data helper inline, it's only used ~5
times and doesn't add much (IMO) over just opencoding it.
Cheers,
Harvey
prev parent reply other threads:[~2008-10-27 19:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-24 23:44 [PATCH] ibmpex: trivial endian annotation in extract_data helper Harvey Harrison
2008-10-27 18:32 ` Darrick J. Wong
2008-10-27 19:26 ` Harvey Harrison [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1225135566.5396.1.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=djwong@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.