All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleksandr Natalenko <oleksandr@redhat.com>
To: Saurav Kashyap <skashyap@marvell.com>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
	Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] qedf: Changed string copy method for "stop_io_on_error" from sprintf to put_user
Date: Wed, 26 Jul 2023 13:34:04 +0200	[thread overview]
Message-ID: <12251400.O9o76ZdvQC@redhat.com> (raw)
In-Reply-To: <182fcf92-913f-81dc-6017-01435821bf80@wdc.com>

[-- Attachment #1: Type: text/plain, Size: 731 bytes --]

Hello.

On středa 26. července 2023 12:55:52 CEST Johannes Thumshirn wrote:
> On 26.07.23 12:12, Saurav Kashyap wrote:
> 
> That one seems to be a duplicate of:
> 
> https://lore.kernel.org/linux-scsi/20230724120241.40495-2-oleksandr@redhat.com/
> 
> Which looks IMHO way nicer than the put_user() calls.

Thanks for checking that submission. Yes, I'd appreciate some reaction on it as a) open-coding what can be done with a simple simple_read_from_buffer() is a questionable decision; and b) there are two more places where the same issue occurs, and the RFC I posted should fix those too.

> Regards,
> 
>      Johannes
> 
> 


-- 
Oleksandr Natalenko (post-factum)
Principal Software Maintenance Engineer

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2023-07-26 11:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-26 10:12 [PATCH] qedf: Changed string copy method for "stop_io_on_error" from sprintf to put_user Saurav Kashyap
2023-07-26 10:55 ` Johannes Thumshirn
2023-07-26 11:34   ` Oleksandr Natalenko [this message]
2023-07-28  6:46 ` Oleksandr Natalenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12251400.O9o76ZdvQC@redhat.com \
    --to=oleksandr@redhat.com \
    --cc=Johannes.Thumshirn@wdc.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=skashyap@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.