From: Peter Zijlstra <peterz@infradead.org>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@linux-foundation.org>,
Nick Piggin <npiggin@suse.de>, Paul Menage <menage@google.com>,
Derek Fults <dfults@sgi.com>,
linux-kernel@vger.kernel.org
Subject: Re: [patch 1/7] cpusets: add dirty map to struct address_space
Date: Tue, 28 Oct 2008 18:46:25 +0100 [thread overview]
Message-ID: <1225215985.15763.36.camel@lappy.programming.kicks-ass.net> (raw)
In-Reply-To: <alpine.DEB.1.10.0810280259500.15270@chino.kir.corp.google.com>
On Tue, 2008-10-28 at 09:08 -0700, David Rientjes wrote:
> @@ -487,6 +488,12 @@ void generic_sync_sb_inodes(struct super_block *sb,
> continue; /* blockdev has wrong queue */
> }
>
> + if (!cpuset_intersects_dirty_nodes(mapping, wbc->nodes)) {
> + /* No node pages under writeback */
> + requeue_io(inode);
> + continue;
> + }
So, aside from all the dirty limit and passing node masks around, this
is the magic bit?
I totally missed it first time around, a short mention in the changelog
might not be undeserved.
next prev parent reply other threads:[~2008-10-28 17:48 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-28 16:08 [patch 1/7] cpusets: add dirty map to struct address_space David Rientjes
2008-10-28 16:08 ` [patch 2/7] pdflush: allow the passing of a nodemask parameter David Rientjes
2008-10-28 16:08 ` [patch 3/7] mm: make page writeback obey cpuset constraints David Rientjes
2008-10-28 17:31 ` Peter Zijlstra
2008-10-28 19:16 ` David Rientjes
2008-10-28 17:32 ` Peter Zijlstra
2008-10-28 19:18 ` David Rientjes
2008-10-30 8:42 ` Peter Zijlstra
2008-10-30 9:10 ` David Rientjes
2008-10-30 9:34 ` Peter Zijlstra
2008-10-28 16:08 ` [patch 4/7] mm: cpuset aware reclaim writeout David Rientjes
2008-10-28 16:08 ` [patch 5/7] mm: throttle writeout with cpuset awareness David Rientjes
2008-10-28 16:08 ` [patch 6/7] cpusets: per cpuset dirty ratios David Rientjes
2008-10-30 6:59 ` Paul Menage
2008-10-30 8:48 ` David Rientjes
2008-10-30 15:28 ` Christoph Lameter
2008-10-30 8:44 ` Peter Zijlstra
2008-10-30 9:03 ` David Rientjes
2008-10-30 9:34 ` Peter Zijlstra
2008-10-30 10:02 ` David Rientjes
2008-10-28 16:08 ` [patch 7/7] cpusets: update documentation for writeback throttling David Rientjes
2008-10-30 16:06 ` Christoph Lameter
2008-10-28 17:37 ` [patch 1/7] cpusets: add dirty map to struct address_space Peter Zijlstra
2008-10-28 20:48 ` David Rientjes
2008-10-29 1:13 ` David Rientjes
2008-10-29 2:24 ` David Rientjes
2008-10-30 8:38 ` Peter Zijlstra
2008-10-28 17:46 ` Peter Zijlstra [this message]
2008-10-28 19:19 ` David Rientjes
-- strict thread matches above, loose matches on Subject: below --
2008-10-30 19:23 [patch 0/7] cpuset writeback throttling David Rientjes
2008-10-30 19:23 ` [patch 1/7] cpusets: add dirty map to struct address_space David Rientjes
2008-11-04 21:09 ` Andrew Morton
2008-11-04 21:20 ` Christoph Lameter
2008-11-04 21:42 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1225215985.15763.36.camel@lappy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=dfults@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
--cc=npiggin@suse.de \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.