All of lore.kernel.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind@infradead.org>
To: Alexey Korolev <akorolev@infradead.org>
Cc: dwmw2@infradead.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH][nandsim] FIX RAM wasting via kmalloc
Date: Wed, 29 Oct 2008 11:27:10 +0200	[thread overview]
Message-ID: <1225272430.4350.16.camel@sauron> (raw)
In-Reply-To: <alpine.LFD.1.10.0810271251540.18203@casper.infradead.org>

On Mon, 2008-10-27 at 12:59 +0000, Alexey Korolev wrote:
> Hi,
> 
> > > Nandsim consumes ~2x more RAM than the density of simulated device. 
> > > It becomes critical if we need to simulate 256MB NAND and run stress tests 
> > > on it.
> > 
> > I'm applying your patch to our local tree, just to test it. But there
> > is a trailing white-space.
> > 
> > [dedekind@gollum ubifs-2.6]$ git-am nandsim
> > Applying FIX RAM wasting via kmalloc
> > .dotest/patch:64: trailing whitespace.
> >                  * then kernel memory alloc runs writeback which goes to
> > the FS
> > warning: 1 line adds whitespace errors.
> > 
> > :-)
> >
> Thanks. I removed the trailing space. Also for just a case did an addtional
> tests to make sure it works fine.
> I think this one should be better :)?

I suggest you to re-send your patch again, with nice commit comments,
because when I applied this patch using git-am, I had to edit the text
to remove junk ">" symbols. It is just nice if your patch does not
require much editing.

Feel free to add:

Tested-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Acked-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>

Thanks.

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

      reply	other threads:[~2008-10-29  9:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-22 15:33 [PATCH][nandsim] FIX RAM wasting via kmalloc Alexey Korolev
2008-10-22 15:49 ` Artem Bityutskiy
2008-10-27  7:18 ` Artem Bityutskiy
2008-10-27 12:59   ` Alexey Korolev
2008-10-29  9:27     ` Artem Bityutskiy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1225272430.4350.16.camel@sauron \
    --to=dedekind@infradead.org \
    --cc=akorolev@infradead.org \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.