From: Eric Paris <eparis@redhat.com>
To: Stephen Smalley <sds@tycho.nsa.gov>
Cc: selinux@tycho.nsa.gov, jmorris@namei.org
Subject: Re: [PATCH 1/2] SELinux: do not check open on dir path walk
Date: Wed, 29 Oct 2008 11:19:17 -0400 [thread overview]
Message-ID: <1225293557.23736.13.camel@localhost.localdomain> (raw)
In-Reply-To: <1225291378.6588.46.camel@moss-spartans.epoch.ncsc.mil>
On Wed, 2008-10-29 at 10:42 -0400, Stephen Smalley wrote:
> On Wed, 2008-10-29 at 10:34 -0400, Eric Paris wrote:
> > Things like link_path_walk check for MAY_EXEC on directories as it walks path
> > names. The open perms checking was actually checking open on these as well.
> > This patch excludes checking open when the only requested permission on the
> > dir was MAY_EXEC. open and opendir both still require open perms.
>
> Would these issues (both directory search and unix socket) have been
> avoided if you had put the open check in the dentry_open hook instead of
> the inode_permission hook?
Both are the result of explicit calls to inode_permission so yes, they
would have been avoided.
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
next prev parent reply other threads:[~2008-10-29 15:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 14:34 [PATCH 1/2] SELinux: do not check open on dir path walk Eric Paris
2008-10-29 14:42 ` Stephen Smalley
2008-10-29 15:19 ` Eric Paris [this message]
2008-10-29 15:24 ` Stephen Smalley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1225293557.23736.13.camel@localhost.localdomain \
--to=eparis@redhat.com \
--cc=jmorris@namei.org \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.