From: Harvey Harrison <harvey.harrison@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Kay Sievers <kay.sievers@vrfy.org>,
Pierre Ossman <drzeus@drzeus.cx>,
linux-kernel <linux-kernel@vger.kernel.org>,
Greg KH <greg@kroah.com>
Subject: Re: mmc: struct device - replace bus_id with dev_name(), dev_set_name()
Date: Wed, 29 Oct 2008 22:15:54 -0700 [thread overview]
Message-ID: <1225343754.5496.14.camel@brick> (raw)
In-Reply-To: <C4E7021A-E5BA-4204-BDC1-D2DCA8CCEE1A@holtmann.org>
On Thu, 2008-10-30 at 05:37 +0100, Marcel Holtmann wrote:
> Hi Harvey,
> >
> > A lot of these helpers don't seem to add that much, would you care for
> > a patch removing them Pierre?
> >
> > Specifically sdio_func_id, sdio_get/set_drvdata don't have that many
> > users.
>
> I prefer if we keep them. Since they take the proper parameter.
> Otherwise the driver has to always got func->dev for everything. Most
> SDIO drivers care of the function and not about the struct device
> underneath it.
>
Sure, it just seemed odd to have a wrapper around a wrapper.
Cheers,
Harvey
next prev parent reply other threads:[~2008-10-30 5:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-30 1:20 mmc: struct device - replace bus_id with dev_name(), dev_set_name() Kay Sievers
2008-10-30 1:48 ` Harvey Harrison
2008-10-30 4:37 ` Marcel Holtmann
2008-10-30 5:15 ` Harvey Harrison [this message]
2008-10-30 9:09 ` Pierre Ossman
2008-10-30 9:06 ` Pierre Ossman
2008-10-30 9:21 ` Kay Sievers
-- strict thread matches above, loose matches on Subject: below --
2009-01-25 22:50 Kay Sievers
2009-02-02 20:09 ` Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1225343754.5496.14.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=drzeus@drzeus.cx \
--cc=greg@kroah.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.