All of lore.kernel.org
 help / color / mirror / Atom feed
From: reinette chatre <reinette.chatre@intel.com>
To: Mirco Tischler <mt-ml@gmx.de>
Cc: "Zhu, Yi" <yi.zhu@intel.com>,
	Arjan van de Ven <arjan@infradead.org>,
	lkml <linux-kernel@vger.kernel.org>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	"John W.Linville" <linville@tuxdriver.com>,
	Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [2.6.28-rc2]: iwl4965 doesn't connect / cfg80211 failure
Date: Thu, 30 Oct 2008 10:55:38 -0700	[thread overview]
Message-ID: <1225389338.1115.338.camel@rc-desk> (raw)
In-Reply-To: <20081030182433.0a4eb471@mtlp.12.dimension>

On Thu, 2008-10-30 at 10:24 -0700, Mirco Tischler wrote:
> On Wed, 29 Oct 2008 14:18:04 +0800, Zhu Yi wrote:
> > Can you try attached patch?
> > 
> > Thanks,
> > -yi
> I did. Didn't solve the problems but here's the output:

That helped us to obtain more information. Could you please try commit
9685e33a2c919c1e95cb7072988fc1e0f0bad3d9 ?

Reproduced here for convenience:

commit 9685e33a2c919c1e95cb7072988fc1e0f0bad3d9
Author: Mohamed Abbas <mohamed.abbas@intel.com>
Date:   Thu Oct 23 23:48:54 2008 -0700

    iwlwifi: clear scanning bits upon failure
    
    In iwl_bg_request_scan function, if we could not send a
    scan command it will go to done.
    In done it does the right thing to call mac80211 with
    scan complete, but the problem is STATUS_SCAN_HW is still
    set causing any future scan to fail. Fix by clearing the scanning status
    bits if scan fails.
    
    Signed-off-by: Mohamed Abbas <mohamed.abbas@intel.com>
    Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>

diff --git a/drivers/net/wireless/iwlwifi/iwl-scan.c b/drivers/net/wireless/iwlwifi/iwl-scan.c
index 3379b41..b0abf89 100644
--- a/drivers/net/wireless/iwlwifi/iwl-scan.c
+++ b/drivers/net/wireless/iwlwifi/iwl-scan.c
@@ -834,6 +834,13 @@ static void iwl_bg_request_scan(struct work_struct *data)
 	return;
 
  done:
+	/* Cannot perform scan. Make sure we clear scanning
+	* bits from status so next scan request can be performed.
+	* If we don't clear scanning status bit here all next scan
+	* will fail
+	*/
+	clear_bit(STATUS_SCAN_HW, &priv->status);
+	clear_bit(STATUS_SCANNING, &priv->status);
 	/* inform mac80211 scan aborted */
 	queue_work(priv->workqueue, &priv->scan_completed);
 	mutex_unlock(&priv->mutex);




  reply	other threads:[~2008-10-30 17:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20081028020212.0dfcb6c9@mtlp.12.dimension>
2008-10-28  1:33 ` [2.6.28-rc2]: iwl4965 doesn't connect / cfg80211 failure Zhu Yi
2008-10-28  1:59   ` Mirco Tischler
2008-10-28  2:19     ` Zhu Yi
2008-10-28  3:19       ` Mirco Tischler
2008-10-28  4:32   ` Arjan van de Ven
2008-10-28  5:23     ` Zhu Yi
2008-10-28 16:24       ` Mirco Tischler
2008-10-28 18:36         ` Johannes Berg
2008-10-28 22:58           ` Mirco Tischler
2008-10-28 23:06             ` Johannes Berg
2008-10-28 23:35             ` Mirco Tischler
2008-10-29  6:18         ` Zhu Yi
2008-10-30 17:24           ` Mirco Tischler
2008-10-30 17:55             ` reinette chatre [this message]
2008-10-31 22:25               ` Mirco Tischler
2008-10-28  2:05 ` Mirco Tischler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1225389338.1115.338.camel@rc-desk \
    --to=reinette.chatre@intel.com \
    --cc=arjan@infradead.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mt-ml@gmx.de \
    --cc=yi.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.