From: Chris Mason <chris.mason@oracle.com>
To: Yan Zheng <zheng.yan@oracle.com>
Cc: linux-btrfs@vger.kernel.org, ukernel@gmail.com
Subject: Re: [PATCH 4/4] Add fallocate support v2
Date: Thu, 30 Oct 2008 14:20:53 -0400 [thread overview]
Message-ID: <1225390853.6533.27.camel@think.oraclecorp.com> (raw)
In-Reply-To: <4909E8B3.6070409@oracle.com>
On Fri, 2008-10-31 at 01:02 +0800, Yan Zheng wrote:
> Hello,
>
> This patch updates btrfs-progs for fallocate support.
Thanks for rediffing these, one question though:
> diff -urp 4/fs/btrfs/ctree.h 5/fs/btrfs/ctree.h
> --- 4/fs/btrfs/ctree.h 2008-10-30 13:45:33.000000000 +0800
> +++ 5/fs/btrfs/ctree.h 2008-10-30 14:21:24.000000000 +0800
> @@ -462,8 +462,9 @@ struct btrfs_root_item {
> u8 level;
> } __attribute__ ((__packed__));
>
> -#define BTRFS_FILE_EXTENT_REG 0
> -#define BTRFS_FILE_EXTENT_INLINE 1
> +#define BTRFS_FILE_EXTENT_INLINE 0
> +#define BTRFS_FILE_EXTENT_REG 1
> +#define BTRFS_FILE_EXTENT_PREALLOC 2
Why do we swap these around?
-chris
prev parent reply other threads:[~2008-10-30 18:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-30 17:02 [PATCH 4/4] Add fallocate support v2 Yan Zheng
2008-10-30 18:20 ` Chris Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1225390853.6533.27.camel@think.oraclecorp.com \
--to=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=ukernel@gmail.com \
--cc=zheng.yan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.