From: Heinz Mauelshagen <heinzm@redhat.com>
To: dm-devel@redhat.com
Cc: heinzm@redhat.com
Subject: [PATCH] dm-stripe: pay attention to failing registration in dm_stripe_init()
Date: Fri, 31 Oct 2008 16:11:09 +0100 [thread overview]
Message-ID: <1225465869.1196.60.camel@o> (raw)
dm_stripe_init() doesn't pay attention to a failing target registration.
Heinz
Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
---
diff -up linux-2.6.27.4/drivers/md/dm-stripe.c.orig1
linux-2.6.27.4/drivers/md/dm-stripe.c
--- linux-2.6.27.4/drivers/md/dm-stripe.c.orig1 2008-10-26
00:05:07.000000000 +0200
+++ linux-2.6.27.4/drivers/md/dm-stripe.c 2008-10-31 16:05:12.000000000
+0100
@@ -322,12 +322,13 @@ int __init dm_stripe_init(void)
r = dm_register_target(&stripe_target);
if (r < 0)
DMWARN("target registration failed");
-
- kstriped = create_singlethread_workqueue("kstriped");
- if (!kstriped) {
- DMERR("failed to create workqueue kstriped");
- dm_unregister_target(&stripe_target);
- return -ENOMEM;
+ else {
+ kstriped = create_singlethread_workqueue("kstriped");
+ if (!kstriped) {
+ DMERR("failed to create workqueue kstriped");
+ dm_unregister_target(&stripe_target);
+ r = -ENOMEM;
+ }
}
return r;
reply other threads:[~2008-10-31 15:11 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1225465869.1196.60.camel@o \
--to=heinzm@redhat.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.