Re: 2.6.27 and good_bytes -= scsi_get_resid(cmd)

[Miquel van Smoorenburg <mikevs@xs4all.net>]

On Tue, 2008-11-04 at 10:32 +0200, Boaz Harrosh wrote:
> Miquel van Smoorenburg wrote:
> > I upgraded to 2.6.27 on a machine with the dpt_i2o scsi driver and
> > I'm seeing some weird number from iostat -x 2. Basically it thinks
> > that the size of every request is 32640 sectors (0xff0000 bytes),
> > and that throws off the stats considerably.

[... dpt_i2o.c patch ...]

> Why does the readl(reply+5) does not return the same number as
> scsi_bufflen(cmd). This is the real problem. 

You're right, ofcourse. Thanks. I had a good look over the code and
reply+5 is wrong. It should be reply + 5*sizeof(u32). In the same
function all other values read from an offset which is a multiple of 4,
which I should have noticed earlier I guess.

I'll send a new patch in a seperate mail.

Mike.