From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KxkPf-0006ae-Dl for mharc-grub-devel@gnu.org; Wed, 05 Nov 2008 10:35:19 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KxkPd-0006Zf-Ao for grub-devel@gnu.org; Wed, 05 Nov 2008 10:35:17 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KxkPb-0006Yg-Mj for grub-devel@gnu.org; Wed, 05 Nov 2008 10:35:16 -0500 Received: from [199.232.76.173] (port=48201 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KxkPb-0006Yd-Ey for grub-devel@gnu.org; Wed, 05 Nov 2008 10:35:15 -0500 Received: from c60.cesmail.net ([216.154.195.49]:1094) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1KxkPa-0001xh-TH for grub-devel@gnu.org; Wed, 05 Nov 2008 10:35:15 -0500 Received: from unknown (HELO smtprelay1.cesmail.net) ([192.168.1.111]) by c60.cesmail.net with ESMTP; 05 Nov 2008 10:35:10 -0500 Received: from [192.168.0.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay1.cesmail.net (Postfix) with ESMTPSA id 8DA5234C6D; Wed, 5 Nov 2008 10:35:09 -0500 (EST) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20081105094353.GB12201@thorin> References: <1224622323.31194.81.camel@localhost.localdomain> <1224784802.9254.56.camel@manoel-laptop> <1224788935.16720.38.camel@localhost.localdomain> <1224885201.7358.53.camel@manoel-laptop> <1225127982.4991.7.camel@dv> <1225814725.6767.20.camel@manoel-laptop> <1225815138.15410.19.camel@localhost.localdomain> <1225822685.6767.28.camel@manoel-laptop> <1225842506.2997.21.camel@dv> <20081105094353.GB12201@thorin> Content-Type: text/plain Date: Wed, 05 Nov 2008 10:35:09 -0500 Message-Id: <1225899309.20394.3.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 (2.22.3.1-1.fc9) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Cc: Manoel , Carlos Roberto do Nascimento Costa , Hollis Blanchard Subject: Re: PPC64 mlongcall gcc flag X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Nov 2008 15:35:17 -0000 On Wed, 2008-11-05 at 10:43 +0100, Robert Millan wrote: > On Tue, Nov 04, 2008 at 06:48:26PM -0500, Pavel Roskin wrote: > > Index: configure.ac > > =================================================================== > > --- configure.ac (revision 1893) > > +++ configure.ac (working copy) > > @@ -291,6 +291,11 @@ > > TARGET_CFLAGS="$TARGET_CFLAGS -malign-jumps=1 -malign-loops=1 -malign-functions=1" > > fi > > fi > > + > > + # Force long calls on PowerPC. > > + if test "x$target_cpu" = xpowerpc; then > > + TARGET_CFLAGS="$TARGET_CFLAGS -mlongcall" > > + fi > > fi > > IIRC we had a case/esac stanza for $target_cpu already. Shouldn't this be added > there instead? I would prefer that we handle similar flags in the same place. It's more reliable (especially in context of further changes) than grouping changes in different flags by conditions. The real question is of course how to avoid or limit -mlongcall, as it makes the modules bigger. We should not need more that 32 Mb for code. -- Regards, Pavel Roskin