From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] mk: toolchain: gcc: query the compiler macros to obtain the gcc version Date: Wed, 23 Mar 2016 11:00:03 +0100 Message-ID: <12259482.yKfMHTRKXF@xps13> References: <1458666816-29778-1-git-send-email-mchandras@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Markos Chandras Return-path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 1C65A2BAA for ; Wed, 23 Mar 2016 11:01:46 +0100 (CET) Received: by mail-wm0-f47.google.com with SMTP id l68so16386209wml.1 for ; Wed, 23 Mar 2016 03:01:46 -0700 (PDT) In-Reply-To: <1458666816-29778-1-git-send-email-mchandras@suse.de> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-03-22 17:13, Markos Chandras: > This is similar to what's being used in the Linux kernel. Querying the > GCC macros directly gives more accurate results compared to -dumpversion > which could vary across distributions. > > Signed-off-by: Markos Chandras > --- > In openSUSE Tumbleweed (and in any other SUSE distribution which > uses (or will use) gcc >= 5), gcc -dumpversion returns '5'. This is on > purpose as discussed in https://bugzilla.opensuse.org/show_bug.cgi?id=941428 > As a result of which, the gcc-4.x comparison (40 against 5) does not > work leading to tons of warnings and failures during build. This patch > aims to change the way the gcc version is obtained by using the gcc macros > directly. > --- Acked-by: Thomas Monjalon Applied, thanks