From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: cmm@us.ibm.com, tytso@mit.edu, sandeen@redhat.com
Cc: linux-ext4@vger.kernel.org,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: [RFC PATCH -V3 9/9] ext4: Fix lockdep recursive locking warning
Date: Fri, 7 Nov 2008 00:19:34 +0530 [thread overview]
Message-ID: <1225997374-10846-9-git-send-email-aneesh.kumar@linux.vnet.ibm.com> (raw)
In-Reply-To: <1225997374-10846-8-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
Indicate that the group locks can be taken in loop.
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---
fs/ext4/mballoc.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index f58de20..34b9b7c 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -2413,6 +2413,7 @@ ext4_mb_store_history(struct ext4_allocation_context *ac)
#define ext4_mb_history_init(sb)
#endif
+static struct lock_class_key alloc_sem_key[NR_BG_LOCKS];
/* Create and initialize ext4_group_info data for the given group. */
int ext4_mb_add_groupinfo(struct super_block *sb, ext4_group_t group,
@@ -2473,7 +2474,9 @@ int ext4_mb_add_groupinfo(struct super_block *sb, ext4_group_t group,
}
INIT_LIST_HEAD(&meta_group_info[i]->bb_prealloc_list);
- init_rwsem(&meta_group_info[i]->alloc_sem);
+ __init_rwsem(&meta_group_info[i]->alloc_sem,
+ "&meta_group_info[i]->alloc_sem",
+ &alloc_sem_key[i]);
meta_group_info[i]->bb_free_root.rb_node = NULL;;
#ifdef DOUBLE_CHECK
--
1.6.0.3.514.g2f91b
next prev parent reply other threads:[~2008-11-06 18:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-06 18:49 [RFC PATCH -V3 1/9] ext4: sparse fixes Aneesh Kumar K.V
2008-11-06 18:49 ` [RFC PATCH -V3 2/9] ext4: Add blocks added during resize to bitmap Aneesh Kumar K.V
2008-11-06 18:49 ` [RFC PATCH -V3 3/9] ext4: Use EXT4_GROUP_INFO_NEED_INIT_BIT during resize Aneesh Kumar K.V
2008-11-06 18:49 ` [RFC PATCH -V3 4/9] ext4: cleanup mballoc header files Aneesh Kumar K.V
2008-11-06 18:49 ` [RFC PATCH -V3 5/9] ext4: Add sparse annotations for the group info semaphore Aneesh Kumar K.V
2008-11-06 18:49 ` [RFC PATCH -V3 6/9] jbd2: Call journal commit callback without holding j_list_lock Aneesh Kumar K.V
2008-11-06 18:49 ` [RFC PATCH -V3 7/9] ext4: don't use blocks freed but not yet committed in buddy cache init Aneesh Kumar K.V
2008-11-06 18:49 ` [RFC PATCH -V3 8/9] ext4: Fix double free of blocks Aneesh Kumar K.V
2008-11-06 18:49 ` Aneesh Kumar K.V [this message]
2008-11-07 8:04 ` [RFC PATCH -V3 9/9] ext4: Fix lockdep recursive locking warning Li Zefan
2008-11-07 16:22 ` Aneesh Kumar K.V
2008-11-08 1:21 ` Li Zefan
2008-11-06 22:37 ` [RFC PATCH -V3 8/9] ext4: Fix double free of blocks Theodore Tso
2008-11-07 16:01 ` Aneesh Kumar K.V
2008-11-06 22:09 ` [RFC PATCH -V3 1/9] ext4: sparse fixes Theodore Tso
2008-11-07 14:20 ` Aneesh Kumar K.V
2008-11-07 14:45 ` Theodore Tso
2008-11-07 15:07 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1225997374-10846-9-git-send-email-aneesh.kumar@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=cmm@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.