From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Ellerman Subject: Re: Is msix_flush_writes() really needed? And multi_msi_*() flawed? Date: Mon, 10 Nov 2008 10:07:50 +1100 Message-ID: <1226272070.7205.4.camel@localhost> References: <4914102D.76E4.0078.0@novell.com> Reply-To: michael@ellerman.id.au Mime-Version: 1.0 Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-pkYCrHaJzYMqlLYUO+If" Return-path: In-Reply-To: <4914102D.76E4.0078.0@novell.com> Sender: linux-pci-owner@vger.kernel.org To: Jan Beulich Cc: linux-pci@vger.kernel.org, xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org --=-pkYCrHaJzYMqlLYUO+If Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Fri, 2008-11-07 at 08:53 +0000, Jan Beulich wrote: > msix_flush_writes() is being called exclusively after calling msi_set_mas= k_bit(), > and that function already does follow writel() by readl() in the MSI-X ca= se. Which makes me wonder why the initial patch was necessary? http://git.kernel.org/?p=3Dlinux/kernel/git/torvalds/linux-2.6.git;a=3Dcomm= it;h=3D988cbb15e00e6f924d052874b40c6a5447f9fdd7 http://git.kernel.org/?p=3Dlinux/kernel/git/torvalds/linux-2.6.git;a=3Dblob= ;f=3Ddrivers/pci/msi.c;h=3Da4ef93ea4c547b78bf80b5b12c9c20101bd3a1ec;hb=3D98= 8cbb15e00e6f924d052874b40c6a5447f9fdd7 AFAICS there was already a readl() in msi_set_mask_bit(), so either the initial patch didn't do anything useful or we're missing the point. cheers --=20 Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person --=-pkYCrHaJzYMqlLYUO+If Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEABECAAYFAkkXbUUACgkQdSjSd0sB4dKvjACfRxpDddv5wiAhau3JkZiJ0OyG W98An0gOVAB0cTC0ItthKxmNasJnUKqO =YKk1 -----END PGP SIGNATURE----- --=-pkYCrHaJzYMqlLYUO+If--