From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Suresh B Siddha <suresh.b.siddha@intel.com>,
Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>,
Ingo Molnar <mingo@elte.hu>, Dipankar Sarma <dipankar@in.ibm.com>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
Vatsa <vatsa@linux.vnet.ibm.com>,
Gautham R Shenoy <ego@in.ibm.com>,
Andi Kleen <andi@firstfloor.org>,
David Collier-Brown <davecb@sun.com>,
Tim Connors <tconnors@astro.swin.edu.au>,
Max Krasnyansky <maxk@qualcomm.com>
Subject: Re: [RFC PATCH v3 0/5] Tunable sched_mc_power_savings=n
Date: Mon, 10 Nov 2008 19:50:16 +0100 [thread overview]
Message-ID: <1226343016.7685.444.camel@twins> (raw)
In-Reply-To: <20081110181526.562.69941.stgit@drishya.in.ibm.com>
a quick response, I'll read them more carefully tomorrow:
- why are the preferred cpu things pointers? afaict using just the cpu
number is both smaller and clearer to the reader.
- in patch 5/5 you do:
+ spin_unlock(&this_rq->lock);
+ double_rq_lock(this_rq, busiest);
we call that double_lock_balance()
- comments go like:
/*
* this is a multi-
* line comment
*/
next prev parent reply other threads:[~2008-11-10 18:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-10 18:32 [RFC PATCH v3 0/5] Tunable sched_mc_power_savings=n Vaidyanathan Srinivasan
2008-11-10 18:33 ` [RFC PATCH v3 1/5] sched: Framework for sched_mc/smt_power_savings=N Vaidyanathan Srinivasan
2008-11-10 18:33 ` [RFC PATCH v3 2/5] sched: favour lower logical cpu number for sched_mc balance Vaidyanathan Srinivasan
2008-11-10 18:33 ` [RFC PATCH v3 3/5] sched: nominate preferred wakeup cpu Vaidyanathan Srinivasan
2008-11-11 13:43 ` Peter Zijlstra
2008-11-11 14:07 ` Gregory Haskins
2008-11-11 15:21 ` Srivatsa Vaddagiri
2008-11-11 15:26 ` Peter Zijlstra
2008-11-11 17:15 ` Vaidyanathan Srinivasan
2008-11-11 17:17 ` Vaidyanathan Srinivasan
2008-11-11 16:48 ` Vaidyanathan Srinivasan
2008-11-11 16:49 ` Balbir Singh
2008-11-11 17:27 ` Vaidyanathan Srinivasan
2008-11-10 18:33 ` [RFC PATCH v3 4/5] sched: bias task wakeups to preferred semi-idle packages Vaidyanathan Srinivasan
2008-11-10 18:33 ` [RFC PATCH v3 5/5] sched: activate active load balancing in new idle cpus Vaidyanathan Srinivasan
2008-11-11 13:47 ` Peter Zijlstra
2008-11-11 17:04 ` Vaidyanathan Srinivasan
2008-11-11 17:21 ` Peter Zijlstra
2008-11-11 17:31 ` Vaidyanathan Srinivasan
2008-11-10 18:50 ` Peter Zijlstra [this message]
2008-11-11 4:52 ` [RFC PATCH v3 0/5] Tunable sched_mc_power_savings=n Vaidyanathan Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1226343016.7685.444.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=andi@firstfloor.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=davecb@sun.com \
--cc=dipankar@in.ibm.com \
--cc=ego@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxk@qualcomm.com \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=svaidy@linux.vnet.ibm.com \
--cc=tconnors@astro.swin.edu.au \
--cc=vatsa@linux.vnet.ibm.com \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.