All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kaiwan N Billimoria <kaiwan@designergraphix.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH RESEND] hwmon: lm70: TI TMP121 support.
Date: Tue, 11 Nov 2008 06:59:22 +0000	[thread overview]
Message-ID: <1226386042.7044.11.camel@kaiwan-1> (raw)
In-Reply-To: <20081022080423.GB11169@roarinelk.homelinux.net>

Hey,

It's working now as expected..
will send in the patch soon,

On Wed, 2008-10-29 at 23:49 -0700, David Brownell wrote:
> On Wednesday 29 October 2008, Kaiwan N Billimoria wrote:
> > On Tue, 2008-10-28 at 03:43 -0700, David Brownell wrote:
> > > On Tuesday 28 October 2008, Kaiwan N Billimoria wrote:
> > > > Hi,
> > > > 
> > > > Got a chance to test this patch today..
> > > > short answer: no it did not seem to work.
> > > 
> > > Well, then can you see what the issue is then?
> 
> Maybe the lm70llp code shouldn't set spi->bits_per_word to 16;
> that seems to be another problem.

Yes, that's one of the issues..in fact the main one.
I keep it at zero now.

> Recall that the whole reason we noticed this bug is that the $SUBJECT
> patch was -- correctly!! -- getting its MSBs from rxbuf[0], but Jean
> noted the lm70 code was different.
Yup neat catch!

Thanks guys,
Later,
Kaiwan.



_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2008-11-11  6:59 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-22  8:04 [lm-sensors] [PATCH RESEND] hwmon: lm70: TI TMP121 support Manuel Lauss
2008-10-23 12:57 ` Jean Delvare
2008-10-23 13:13 ` Manuel Lauss
2008-10-23 13:20 ` Jean Delvare
2008-10-23 13:30 ` Manuel Lauss
2008-10-23 14:00 ` Manuel Lauss
2008-10-23 16:53 ` David Brownell
2008-10-23 17:09 ` Jean Delvare
2008-10-23 17:46 ` David Brownell
2008-10-23 17:53 ` Jean Delvare
2008-10-23 18:37 ` David Brownell
2008-10-24  8:26 ` Kaiwan N Billimoria
2008-10-24  9:21 ` David Brownell
2008-10-24 14:04 ` Kaiwan N Billimoria
2008-10-28  8:04 ` Kaiwan N Billimoria
2008-10-28 10:43 ` David Brownell
2008-10-30  6:44 ` Kaiwan N Billimoria
2008-10-30  6:49 ` David Brownell
2008-11-11  6:59 ` Kaiwan N Billimoria [this message]
2008-11-12  7:49 ` Kaiwan N Billimoria
2008-11-12 20:39 ` Jean Delvare
2008-11-12 22:06 ` Manuel Lauss
2008-11-13 10:05 ` Jean Delvare
2008-11-13 11:54 ` Manuel Lauss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1226386042.7044.11.camel@kaiwan-1 \
    --to=kaiwan@designergraphix.com \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.