From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hollis Blanchard Date: Tue, 11 Nov 2008 14:56:20 +0000 Subject: RE: [PATCH 05 of 14] ppc: Create disassemble.h to extract Message-Id: <1226415380.458.2.camel@localhost.localdomain> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-ppc@vger.kernel.org On Tue, 2008-11-11 at 11:23 +0800, Liu Yu wrote: > Since this header is created, will you consider to > unify the argument list of kmppc_emul_tlbre/tlbwe/tlbsx, such as (struct > kvm_vcpu *vcpu, u32 inst)? > > > > -----Original Message----- > > From: kvm-owner@vger.kernel.org > > [mailto:kvm-owner@vger.kernel.org] On Behalf Of Hollis Blanchard > > Sent: Wednesday, November 05, 2008 11:36 PM > > To: avi@redhat.com > > Cc: kvm@vger.kernel.org; kvm-ppc@vger.kernel.org > > Subject: [PATCH 05 of 14] ppc: Create disassemble.h to > > extract instructionfields > > > > This is used in a couple places in KVM, but isn't KVM-specific. > > > > However, this patch doesn't modify other in-kernel emulation code: > > - xmon uses a direct copy of ppc_opc.c from binutils > > - emulate_instruction() doesn't need it because it can use a series > > of mask tests. > > > > Signed-off-by: Hollis Blanchard > > Acked-by: Paul Mackerras Since tlbwe (et al) are now handled completely in core-specific code, I don't see why you're asking... -- Hollis Blanchard IBM Linux Technology Center