From: Harvey Harrison <harvey.harrison@gmail.com>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Al Viro <viro@ZenIV.linux.org.uk>,
linux1394-devel@lists.sourceforge.net
Subject: Re: [RFC-PATCH] ieee1394: endian annotations of drivers/ieee1394
Date: Wed, 12 Nov 2008 10:53:46 -0800 [thread overview]
Message-ID: <1226516026.16649.11.camel@brick> (raw)
In-Reply-To: <491B2309.1090900@s5r6.in-berlin.de>
On Wed, 2008-11-12 at 19:40 +0100, Stefan Richter wrote:
> Harvey Harrison wrote:
> > Annotations are mostly trivial, quadlet_t -> __be32, octlet_t -> __be64
> > which will have no effect on compiled code.
>
>
> I haven't looked at it yet but have point out one important thing:
> This is one of the many issues in drivers/ieee1394 which have already
> been fixed by introducing drivers/firewire. I appreciate the work which
> you put into this, but I don't know yet if we want to take it in.
No worries, I've just been working on getting things down to a level where
__CHECK_ENDIAN__ could be enabled by default and this was one of the
remaining 'noisier' areas in an allyesconfig. In the end the patches
didn't end up being too intrusive other than the csr.c and sbp.c bits.
Cheers,
Harvey
next prev parent reply other threads:[~2008-11-12 18:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-12 18:25 [RFC-PATCH] ieee1394: endian annotations of drivers/ieee1394 Harvey Harrison
2008-11-12 18:40 ` Stefan Richter
2008-11-12 18:53 ` Harvey Harrison [this message]
2008-11-22 11:18 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1226516026.16649.11.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=stefanr@s5r6.in-berlin.de \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.