All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: rostedt@goodmis.org, mingo@elte.hu, akpm@linux-foundation.org,
	fweisbec@gmail.com
Cc: linux-kernel@vger.kernel.org,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: [PATCH] Fix writing to trace/trace_options
Date: Sun, 16 Nov 2008 16:07:58 +0530	[thread overview]
Message-ID: <1226831883-26362-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> (raw)

writing to trace/trace_options use the index of the array
to find the value of the flag. With branch tracer flag
defined conditionally, this breaks writing to trace_options
with branch tracer disabled.

Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>

---
 kernel/trace/trace.c |    2 --
 kernel/trace/trace.h |    2 --
 2 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 004aafd..ef7fe15 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -259,9 +259,7 @@ static const char *trace_options[] = {
 	"sched-tree",
 	"ftrace_printk",
 	"ftrace_preempt",
-#ifdef CONFIG_BRANCH_TRACER
 	"branch",
-#endif
 	"annotate",
 	"dump",
 	NULL
diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h
index b24d350..d048b63 100644
--- a/kernel/trace/trace.h
+++ b/kernel/trace/trace.h
@@ -481,9 +481,7 @@ enum trace_iterator_flags {
 	TRACE_ITER_SCHED_TREE		= 0x200,
 	TRACE_ITER_PRINTK		= 0x400,
 	TRACE_ITER_PREEMPTONLY		= 0x800,
-#ifdef CONFIG_BRANCH_TRACER
 	TRACE_ITER_BRANCH		= 0x1000,
-#endif
 	TRACE_ITER_ANNOTATE		= 0x2000,
 	TRACE_ITER_DUMP			= 0x4000,
 };
-- 
tg: (e186e8e..) an/branch-tracer-fix.patch (depends on: an/ext4-ftrace-test.patch)

             reply	other threads:[~2008-11-16 10:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-16 10:37 Aneesh Kumar K.V [this message]
2008-11-16 10:37 ` [PATCH] ftrace: Add new entry type TRACE_BIN_DUMP Aneesh Kumar K.V
2008-11-16 10:38   ` [PATCH] ftrace: add proper bin iterator support Aneesh Kumar K.V
2008-11-16 10:38     ` [PATCH] ftrace: Add debug_dump trace to dump binary data from kernel to userspace Aneesh Kumar K.V
2008-11-16 10:38       ` [PATCH] ftrace: Add debug_print trace to print " Aneesh Kumar K.V
2008-11-16 10:38         ` [PATCH] ftrace: Add dump iteator Aneesh Kumar K.V
2008-11-16 10:46 ` [PATCH] Fix writing to trace/trace_options Aneesh Kumar K.V
2008-11-16 15:07   ` Steven Rostedt
2008-11-17 11:17   ` Ingo Molnar
2008-11-17 13:11     ` Aneesh Kumar K.V
2008-11-18 14:06       ` Ingo Molnar
2008-11-16 15:05 ` Steven Rostedt
2008-11-17 11:08 ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1226831883-26362-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com \
    --to=aneesh.kumar@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.