All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	James Morris <jmorris@namei.org>,
	Al Viro <viro@ZenIV.linux.org.uk>,
	David Safford <safford@watson.ibm.com>,
	Serge Hallyn <serue@linux.vnet.ibm.com>,
	Mimi Zohar <zohar@us.ibm.com>
Subject: Re: [PATCH 2/4] integrity: Linux Integrity Module(LIM)
Date: Mon, 17 Nov 2008 14:09:40 -0500	[thread overview]
Message-ID: <1226948980.2927.33.camel@localhost.localdomain> (raw)
In-Reply-To: <20081117160515.GA25459@infradead.org>

On Mon, 2008-11-17 at 11:05 -0500, Christoph Hellwig wrote: 
> On Wed, Nov 12, 2008 at 10:47:12PM -0500, Mimi Zohar wrote:
> > This version resolves the merge issues resulting from the removal
> > of the nameidata parameter to inode_permission(), by moving the
> > integrity_inode_permission() call from inode_permission() to
> > may_open(), and renaming the hook to integrity_nameidata_check().
> 
> Still neither a good parameter nor a good name.  If you look at fsdevel
> you'll see that a patch for the next merged window is already out and
> in Al's to be applied queue that removes the nameidata there.  A
> strcut path and maybe the MAY_ lookup flags should be enough for you,
> and a integrity_path_check also sounds like it really does what you
> want.

Ok. So, instead of integrity_nameidata_check(nd, flags), call it
integrity_path_check(path, flags). 

Perhaps I'm looking at the wrong vfs tree, but I don't see the changes.
Where is fsdevel? 

> Also please merge the last radix tree patch into this one so tat it's
> possible to review the code that actually goes in instead of replacing
> a large part of it in a follow-up patch.

np

Mimi


  reply	other threads:[~2008-11-17 19:10 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-13  3:47 [PATCH 0/4] integrity Mimi Zohar
2008-11-13  3:47 ` [PATCH 1/4] integrity: TPM internel kernel interface Mimi Zohar
2008-11-13  3:47 ` [PATCH 2/4] integrity: Linux Integrity Module(LIM) Mimi Zohar
2008-11-14 22:15   ` Andrew Morton
2008-11-17 19:04     ` Mimi Zohar
2008-11-17 16:05   ` Christoph Hellwig
2008-11-17 19:09     ` Mimi Zohar [this message]
2008-11-18 13:29       ` Christoph Hellwig
2008-11-13  3:47 ` [PATCH 3/4] integrity: IMA as an integrity service provider Mimi Zohar
2008-11-14 22:15   ` Andrew Morton
2008-11-17 19:05     ` Mimi Zohar
2008-11-13  3:47 ` [PATCH 4/4] integrity: IMA radix tree Mimi Zohar
2008-11-14 22:15   ` Andrew Morton
2008-11-17 19:05     ` Mimi Zohar
2008-11-14 22:18 ` [PATCH 0/4] integrity Andrew Morton
2008-11-17 20:42   ` david safford
2008-12-03 23:29   ` James Morris
  -- strict thread matches above, loose matches on Subject: below --
2008-11-20 16:43 Mimi Zohar
2008-11-20 16:43 ` [PATCH 2/4] integrity: Linux Integrity Module(LIM) Mimi Zohar
2008-11-20 17:45   ` Christoph Hellwig
2008-11-20 19:21     ` david safford
2008-11-20 19:26       ` Christoph Hellwig
2008-11-21 12:37         ` david safford
2008-11-21 17:45   ` Dave Hansen
2008-11-21 17:46   ` Dave Hansen
2008-11-21 19:10     ` Mimi Zohar
2008-11-21 17:48   ` Dave Hansen
2008-11-21 19:09     ` Mimi Zohar
2008-11-21 17:53   ` Dave Hansen
2008-11-21 19:10     ` Mimi Zohar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1226948980.2927.33.camel@localhost.localdomain \
    --to=zohar@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=hch@infradead.org \
    --cc=jmorris@namei.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=safford@watson.ibm.com \
    --cc=serue@linux.vnet.ibm.com \
    --cc=viro@ZenIV.linux.org.uk \
    --cc=zohar@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.