From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: hash_page_sync should only be used on SMP & STD_MMU_32
Date: Thu, 20 Nov 2008 15:47:27 +1100 [thread overview]
Message-ID: <1227156447.7185.201.camel@pasglop> (raw)
In-Reply-To: <1227109984-22195-1-git-send-email-galak@kernel.crashing.org>
On Wed, 2008-11-19 at 09:53 -0600, Kumar Gala wrote:
> Clean up the ifdefs so we only use hash_page_sync if we are
> CONFIG_SMP && CONFIG_PPC_STD_MMU_32
>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
> arch/powerpc/mm/pgtable_32.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/powerpc/mm/pgtable_32.c b/arch/powerpc/mm/pgtable_32.c
> index c31d6d2..44fbc81 100644
> --- a/arch/powerpc/mm/pgtable_32.c
> +++ b/arch/powerpc/mm/pgtable_32.c
> @@ -48,7 +48,7 @@ EXPORT_SYMBOL(ioremap_bot); /* aka VMALLOC_END */
>
> extern char etext[], _stext[];
>
> -#ifdef CONFIG_SMP
> +#if defined(CONFIG_SMP) && defined(CONFIG_PPC_STD_MMU_32)
> extern void hash_page_sync(void);
> #endif
>
> @@ -127,7 +127,7 @@ pgtable_t pte_alloc_one(struct mm_struct *mm, unsigned long address)
>
> void pte_free_kernel(struct mm_struct *mm, pte_t *pte)
> {
> -#ifdef CONFIG_SMP
> +#if defined(CONFIG_SMP) && defined(CONFIG_PPC_STD_MMU_32)
> hash_page_sync();
> #endif
> free_page((unsigned long)pte);
> @@ -135,7 +135,7 @@ void pte_free_kernel(struct mm_struct *mm, pte_t *pte)
>
> void pte_free(struct mm_struct *mm, pgtable_t ptepage)
> {
> -#ifdef CONFIG_SMP
> +#if defined(CONFIG_SMP) && defined(CONFIG_PPC_STD_MMU_32)
> hash_page_sync();
> #endif
> pgtable_page_dtor(ptepage);
prev parent reply other threads:[~2008-11-20 4:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-19 15:53 [PATCH] powerpc: hash_page_sync should only be used on SMP & STD_MMU_32 Kumar Gala
2008-11-20 4:47 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1227156447.7185.201.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.