From: Alexander Graf <agraf@suse.de>
To: kvm@vger.kernel.org
Cc: joro@8bytes.org, anthony@codemonkey.ws, avi@redhat.com
Subject: [PATCH 12/12] Accelerate nested SVM by emulating parts of GIF=0 v6
Date: Fri, 21 Nov 2008 16:14:42 +0100 [thread overview]
Message-ID: <1227280482-25361-13-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1227280482-25361-12-git-send-email-agraf@suse.de>
Until this patch we bounced between the VM and the VMM for a couple of
instructions after CLGI, only to find out that yet another SVM instruction
follows.
Since roundtrips are really expensive, it's a lot faster to emulate these
few instructions. Now we can execute CLGI/VMLOAD/VMRUN on one intercept and
VMEXIT/VMSAVE on another. This is a major speed improvement!
(introduced in v6, optional)
Signed-off-by: Alexander Graf <agraf@suse.de>
---
arch/x86/kvm/svm.c | 69 ++++++++++++++++++++++++++++++++++++++++++++++++++++
1 files changed, 69 insertions(+), 0 deletions(-)
diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
index 83332d7..e246104 100644
--- a/arch/x86/kvm/svm.c
+++ b/arch/x86/kvm/svm.c
@@ -79,6 +79,11 @@ static int nested_svm_vmsave(struct vcpu_svm *svm, void *nested_vmcb,
void *arg2, void *opaque);
static int nested_svm_check_exception(struct vcpu_svm *svm, unsigned nr,
bool has_error_code, u32 error_code);
+static int vmload_interception(struct vcpu_svm *svm, struct kvm_run *kvm_run);
+static int vmsave_interception(struct vcpu_svm *svm, struct kvm_run *kvm_run);
+static int vmrun_interception(struct vcpu_svm *svm, struct kvm_run *kvm_run);
+static int stgi_interception(struct vcpu_svm *svm, struct kvm_run *kvm_run);
+
static inline struct vcpu_svm *to_svm(struct kvm_vcpu *vcpu)
{
@@ -1456,6 +1461,50 @@ static int nested_svm_exit_handled(struct vcpu_svm *svm, bool kvm_override)
nested_svm_exit_handled_real);
}
+static int nested_svm_emulate(struct vcpu_svm *svm, struct kvm_run *kvm_run)
+{
+ int er;
+ u32 opcode = 0;
+ unsigned long rip;
+ unsigned long rip_linear;
+
+ svm->vmcb->save.rax = svm->vcpu.arch.regs[VCPU_REGS_RAX];
+ svm->vmcb->save.rsp = svm->vcpu.arch.regs[VCPU_REGS_RSP];
+ svm->vmcb->save.rip = svm->vcpu.arch.regs[VCPU_REGS_RIP];
+ rip = svm->vcpu.arch.regs[VCPU_REGS_RIP];
+ rip_linear = rip + svm_seg(&svm->vcpu, VCPU_SREG_CS)->base;
+
+ er = emulator_read_std(rip_linear, (void *)&opcode, 3, &svm->vcpu);
+ if (er != X86EMUL_CONTINUE)
+ return er;
+ er = EMULATE_FAIL;
+
+ switch (opcode) {
+ case 0xda010f:
+ vmload_interception(svm, kvm_run);
+ er = EMULATE_DONE;
+ break;
+ case 0xd8010f:
+ vmrun_interception(svm, kvm_run);
+ er = EMULATE_DONE;
+ break;
+ case 0xdb010f:
+ vmsave_interception(svm, kvm_run);
+ er = EMULATE_DONE;
+ break;
+ case 0xdc010f:
+ stgi_interception(svm, kvm_run);
+ er = EMULATE_DONE;
+ break;
+ default:
+ nsvm_printk("NSVM: Opcode %x unknown\n", opcode);
+ }
+
+ nsvm_printk("NSVM: svm emul at 0x%lx -> %d\n", rip, er);
+
+ return er;
+}
+
static int nested_svm_vmexit_real(struct vcpu_svm *svm, void *arg1,
void *arg2, void *opaque)
{
@@ -1551,6 +1600,9 @@ static int nested_svm_vmexit(struct vcpu_svm *svm)
kvm_mmu_reset_context(&svm->vcpu);
kvm_mmu_load(&svm->vcpu);
+ /* KVM calls vmsave after vmrun, so let's run it now if we can */
+ nested_svm_emulate(svm, NULL);
+
return 0;
}
@@ -1773,6 +1825,23 @@ static int clgi_interception(struct vcpu_svm *svm, struct kvm_run *kvm_run)
svm_clear_vintr(svm);
svm->vmcb->control.int_ctl &= ~V_IRQ_MASK;
+ /* Let's try to emulate as many instructions as possible in GIF=0 */
+
+ while(true) {
+ int er;
+
+ er = emulate_instruction(&svm->vcpu, kvm_run, 0, 0, 0);
+ nsvm_printk("NSVM: emulating at 0x%lx -> %d\n", svm->vcpu.arch.regs[VCPU_REGS_RIP], er);
+
+ /* So we can now emulate the SVM instructions that most probably
+ occur at the end of the codepath */
+ if (er != EMULATE_DONE) {
+ while (true)
+ if (nested_svm_emulate(svm, kvm_run) == EMULATE_FAIL)
+ break;
+ break;
+ }
+ }
return 1;
}
--
1.5.6
next prev parent reply other threads:[~2008-11-21 15:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-21 15:14 [PATCH 00/12] Add support for nested SVM (kernel) v6 Alexander Graf
2008-11-21 15:14 ` [PATCH 01/12] Clean up VINTR setting v6 Alexander Graf
2008-11-21 15:14 ` [PATCH 02/12] Move EFER and MSR constants to generic x86 code v6 Alexander Graf
2008-11-21 15:14 ` [PATCH 03/12] Add helper functions for nested SVM v6 Alexander Graf
2008-11-21 15:14 ` [PATCH 04/12] Implement GIF, clgi and stgi v6 Alexander Graf
2008-11-21 15:14 ` [PATCH 05/12] Implement hsave v6 Alexander Graf
2008-11-21 15:14 ` [PATCH 06/12] Add VMLOAD and VMSAVE handlers v6 Alexander Graf
2008-11-21 15:14 ` [PATCH 07/12] Add VMRUN handler v6 Alexander Graf
2008-11-21 15:14 ` [PATCH 08/12] Add VMEXIT handler and intercepts v6 Alexander Graf
2008-11-21 15:14 ` [PATCH 09/12] Allow read access to MSR_VM_VR v6 Alexander Graf
2008-11-21 15:14 ` [PATCH 10/12] Allow setting the SVME bit v6 Alexander Graf
2008-11-21 15:14 ` [PATCH 11/12] Only allow setting of EFER_SVME when CPUID SVM is set v6 Alexander Graf
2008-11-21 15:14 ` Alexander Graf [this message]
2008-11-21 16:53 ` [PATCH 12/12] Accelerate nested SVM by emulating parts of GIF=0 v6 Avi Kivity
2008-11-21 16:58 ` Alexander Graf
2008-11-21 17:07 ` Avi Kivity
2008-11-21 17:14 ` Alexander Graf
2008-11-21 17:18 ` Avi Kivity
2008-11-21 17:35 ` Alexander Graf
2008-11-21 15:23 ` [PATCH 07/12] Add VMRUN handler v6 Muli Ben-Yehuda
2008-11-21 15:26 ` Alexander Graf
2008-11-21 15:35 ` Alexander Graf
2008-11-23 8:06 ` Muli Ben-Yehuda
2008-11-23 13:48 ` Alexander Graf
2008-11-23 15:09 ` Muli Ben-Yehuda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1227280482-25361-13-git-send-email-agraf@suse.de \
--to=agraf@suse.de \
--cc=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.