From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Ribeiro Subject: Re: [patch 05/14] mfd: PCAP2 driver Date: Sun, 23 Nov 2008 05:06:02 -0200 Message-ID: <1227423962.3148.74.camel@brutus> References: <20081121160403.073751031@dodger.lab.datenfreihafen.org> <200811221819.53186.david-b@pacbell.net> <1227411537.3148.22.camel@brutus> <200811222059.59806.david-b@pacbell.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Stefan Schmidt , eric.y.miao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, sameo-RWuK6r/cQWRpLGFMi4vTTA@public.gmane.org, linux-arm-kernel-xIg/pKzrS19vn6HldHNs0ANdhmdF6hFW@public.gmane.org, Stefan Schmidt To: David Brownell Return-path: In-Reply-To: <200811222059.59806.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org RW0gU8OhYiwgMjAwOC0xMS0yMiDDoHMgMjA6NTkgLTA4MDAsIERhdmlkIEJyb3duZWxsIGVzY3Jl dmV1Ogo+ID4gSSB0cmllZCBzcGlfd3JpdGVfdGhlbl9yZWFkIGJlZm9yZSwgYnV0IGl0IGRpZG4n dCB3b3JrLiBJIHN1cHBvc2VkIGl0Cj4gPiB3YXMgYmVjYXVzZSBpdCB3YXMgZG9pbmcgMiB0cmFu c2ZlcnMgYXMgdGhlIHNlY29uZCB0cmFuc2ZlciByeF9idWYKPiA+IGFsd2F5cyBjYW1lIHplcm9l ZC4KPiAKPiBZb3UgbWF5IGhhdmUgYmVlbiB1c2luZyBpdCB3cm9uZy4gIEFsc28sIHZlcmlmeSBh Z2FpbnN0Cj4gY3VycmVudCBrZXJuZWxzIC4uLiB0aGVyZSBoYXZlIGJlZW4gYnVnZml4ZXMgdG8g cHhhMnh4X3NwaS4KPiAKPiA+IEkgc2VlIHRoYXQgY29tbWl0IAo+ID4gZjliOTBlMzljYmM1YzRk NmVmNjAwMjJmZDFmMjVkNTQxZGYwYWFkMSBjaGFuZ2VkIGl0IHRvIGRvIGEgc2luZ2xlCj4gPiB0 cmFuc2Zlciwgc28gaSB3aWxsIHRyeSBpdCBhZ2Fpbi4KPiAKPiBVbmxlc3MgaXQgbmVlZHMgdGhl IGZ1bGwgZHVwbGV4IGNhcGFiaWxpdHkgb2YgU1BJLCB0aGVuCj4geW91IHNob3VsZCBiZSBhYmxl IHRvIG1ha2Ugd3JpdGVfdGhlbl9yZWFkIHdvcmsgLi4uIG9uCj4gdGhlIG90aGVyIGhhbmQsIGlm IHlvdSBkbyBuZWVkIGZ1bGwgZHVwbGV4LCB0aGVuIHlvdQo+IHNob3VsZCBhZGRyZXNzIHRoZSBE TUEuICAoQW5kIGJ5dGVzd2FwcGluZywgZWl0aGVyIHdheS4pCgpXZWxsLCBpIGd1ZXNzIGl0IGlz IGZ1bGwgZHVwbGV4LCBhcyBpIHNldCBzcGlfdHJhbnNmZXIubGVuIHRvIDQgYnl0ZXMsCndyaXRl IDQgYnl0ZXMgX2FuZF8gcmVhZCA0IGJ5dGVzIHRvL2Zyb20gdGhlIGNoaXAuCgpJJ20gbG9va2lu ZyBhdCB3cml0ZV90aGVuX3JlYWQgYW5kIGlmIEkgcmVhZCBpdCBjb3JyZWN0bHksIGl0IHNlbmRz IG5fdHgKYnl0ZXMgb2YgZGF0YSBwbHVzIG5fcnggYnl0ZXMgb2Ygbm90aGluZywgYW5kIGRpc2Nh cmRzIG5fdHggYnl0ZXMgZnJvbQp0aGUgc3RhcnQgb2YgdGhlIHJlY2VpdmUgYnVmZmVyIGNvbnNp ZGVyaW5nIG9ubHkgbl9yeCBieXRlcyBmcm9tIHRoZSBlbmQKb2YgdGhlIHJlY2VpdmUgYnVmZmVy LiBUaGlzIGlzIG5vdCB3aGF0IGkgd2FudC4KCkNhbiB5b3UgYmUgbW9yZSBkZXNjcmlwdGl2ZSBv biAiYWRkcmVzcyB0aGUgRE1BIj8gSW0gbm90IGZhbWlsaWFyIG9uCndoYXQgaXMgdGhlIGlzc3Vl IGhlcmUuCgpJIHdpbGwgdGFrZSBjYXJlIG9mIGJ5dGUgc3dhcHBpbmcgZm9yIHRoZSBuZXh0IHBh dGNoLgoKLS0gCkRhbmllbCBSaWJlaXJvCgoKLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQpUaGlzIFNGLk5ldCBl bWFpbCBpcyBzcG9uc29yZWQgYnkgdGhlIE1vYmxpbiBZb3VyIE1vdmUgRGV2ZWxvcGVyJ3MgY2hh bGxlbmdlCkJ1aWxkIHRoZSBjb29sZXN0IExpbnV4IGJhc2VkIGFwcGxpY2F0aW9ucyB3aXRoIE1v YmxpbiBTREsgJiB3aW4gZ3JlYXQgcHJpemVzCkdyYW5kIHByaXplIGlzIGEgdHJpcCBmb3IgdHdv IHRvIGFuIE9wZW4gU291cmNlIGV2ZW50IGFueXdoZXJlIGluIHRoZSB3b3JsZApodHRwOi8vbW9i bGluLWNvbnRlc3Qub3JnL3JlZGlyZWN0LnBocD9iYW5uZXJfaWQ9MTAwJnVybD0vCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCnNwaS1kZXZlbC1nZW5lcmFs IG1haWxpbmcgbGlzdApzcGktZGV2ZWwtZ2VuZXJhbEBsaXN0cy5zb3VyY2Vmb3JnZS5uZXQKaHR0 cHM6Ly9saXN0cy5zb3VyY2Vmb3JnZS5uZXQvbGlzdHMvbGlzdGluZm8vc3BpLWRldmVsLWdlbmVy YWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756745AbYKWHGY (ORCPT ); Sun, 23 Nov 2008 02:06:24 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750890AbYKWHGO (ORCPT ); Sun, 23 Nov 2008 02:06:14 -0500 Received: from yx-out-2324.google.com ([74.125.44.28]:3773 "EHLO yx-out-2324.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750832AbYKWHGN (ORCPT ); Sun, 23 Nov 2008 02:06:13 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:x-mailer:content-transfer-encoding; b=gUtcw37raFV1LTFIckhNMtBAj7VYy5E9YeDIZzq4v7+yLSMf/X7rmFH+mfsuRAOf0c /nPpc/OALzeCUQIKnTySe3cZEEGoUj+MQrb5CSlSgKtB4KPV8RpQQ/SIdOGZZTPlQPi6 bNbpQLECMnGznuklQ4VkgJK+c6v9ZPRvkMrwE= Subject: Re: [spi-devel-general] [patch 05/14] mfd: PCAP2 driver From: Daniel Ribeiro To: David Brownell Cc: Stefan Schmidt , spi-devel-general@lists.sourceforge.net, Stefan Schmidt , eric.y.miao@gmail.com, linux-kernel@vger.kernel.org, sameo@openedhand.com, linux-arm-kernel@lists.arm.linux.org.uk In-Reply-To: <200811222059.59806.david-b@pacbell.net> References: <20081121160403.073751031@dodger.lab.datenfreihafen.org> <200811221819.53186.david-b@pacbell.net> <1227411537.3148.22.camel@brutus> <200811222059.59806.david-b@pacbell.net> Content-Type: text/plain; charset=UTF-8 Date: Sun, 23 Nov 2008 05:06:02 -0200 Message-Id: <1227423962.3148.74.camel@brutus> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Sáb, 2008-11-22 às 20:59 -0800, David Brownell escreveu: > > I tried spi_write_then_read before, but it didn't work. I supposed it > > was because it was doing 2 transfers as the second transfer rx_buf > > always came zeroed. > > You may have been using it wrong. Also, verify against > current kernels ... there have been bugfixes to pxa2xx_spi. > > > I see that commit > > f9b90e39cbc5c4d6ef60022fd1f25d541df0aad1 changed it to do a single > > transfer, so i will try it again. > > Unless it needs the full duplex capability of SPI, then > you should be able to make write_then_read work ... on > the other hand, if you do need full duplex, then you > should address the DMA. (And byteswapping, either way.) Well, i guess it is full duplex, as i set spi_transfer.len to 4 bytes, write 4 bytes _and_ read 4 bytes to/from the chip. I'm looking at write_then_read and if I read it correctly, it sends n_tx bytes of data plus n_rx bytes of nothing, and discards n_tx bytes from the start of the receive buffer considering only n_rx bytes from the end of the receive buffer. This is not what i want. Can you be more descriptive on "address the DMA"? Im not familiar on what is the issue here. I will take care of byte swapping for the next patch. -- Daniel Ribeiro