From: Ben Hutchings <bhutchings@solarflare.com>
To: Jan-Bernd Themann <ossthema@de.ibm.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
tklein@de.ibm.com, Christoph Raisch <raisch@de.ibm.com>,
jb.billaud@gmail.com, hering2@de.ibm.com
Subject: Re: [RFC PATCH] lro: ip fragment checking
Date: Mon, 24 Nov 2008 16:51:08 +0000 [thread overview]
Message-ID: <1227545468.3162.4.camel@achroite> (raw)
In-Reply-To: <492ACEC4.3020702@de.ibm.com>
On Mon, 2008-11-24 at 16:56 +0100, Jan-Bernd Themann wrote:
> Currently there is no checking in the LRO receive path whether
> TCP packets are ip fragmented. We should not consider
> those packets for aggregation.
> I'm not sure if this checking is actually required. Does anyone
> know if it is possible to get fragmented TCP packets without
> the tcp stack changing the MSS size?
> This patch introduces explicit checking. Any objections?
LRO depends on the hardware performing TCP checksum offload, and the TCP
checksum cannot be verified for IP fragments in isolation. So I think
drivers should not be passing fragments into inet_lro or should reject
them in its get_frag_header() or get_skb_header() method. Certainly sfc
doesn't pass fragments into inet_lro because they have not been
checksummed.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2008-11-24 16:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-24 15:56 [RFC PATCH] lro: ip fragment checking Jan-Bernd Themann
2008-11-24 16:51 ` Ben Hutchings [this message]
2008-11-24 21:04 ` Brandeburg, Jesse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1227545468.3162.4.camel@achroite \
--to=bhutchings@solarflare.com \
--cc=hering2@de.ibm.com \
--cc=jb.billaud@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ossthema@de.ibm.com \
--cc=raisch@de.ibm.com \
--cc=tklein@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.