All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Peter Ujfalusi <peter.ujfalusi@nokia.com>
Subject: [PATCH 02/13] ASoC: TWL4030: Disable soft-volume
Date: Tue, 25 Nov 2008 15:44:38 +0000	[thread overview]
Message-ID: <1227627889-8373-2-git-send-email-broonie@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1227627889-8373-1-git-send-email-broonie@opensource.wolfsonmicro.com>

From: Peter Ujfalusi <peter.ujfalusi@nokia.com>

Keep Soft-volume disabled for now, since if it is enabled
the FGAIN volume controls are not working in the current
configuration:
CODEC_MODE:OPT_MODE = 1
OPTION:ARXR2_EN = 1
OPTION:ARXL2_EN = 1
OPTION:ARXR1_EN = 0
OPTION:ARXL1_VRX_EN = 0
RX_PATH_SEL:RXL1_SEL = 0x0 (or 0x1)
RX_PATH_SEL:RXR1_SEL = 0x0 (or 0x1)

After the patch, FGAIN volume control works.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
 sound/soc/codecs/twl4030.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/soc/codecs/twl4030.c b/sound/soc/codecs/twl4030.c
index 3348951..49c7da3 100644
--- a/sound/soc/codecs/twl4030.c
+++ b/sound/soc/codecs/twl4030.c
@@ -87,7 +87,7 @@ static const u8 twl4030_reg[TWL4030_CACHEREGNUM] = {
 	0x00, /* REG_ALC_SET1		(0x2C)	*/
 	0x00, /* REG_ALC_SET2		(0x2D)	*/
 	0x00, /* REG_BOOST_CTL		(0x2E)	*/
-	0x01, /* REG_SOFTVOL_CTL	(0x2F)	*/
+	0x00, /* REG_SOFTVOL_CTL	(0x2F)	*/
 	0x00, /* REG_DTMF_FREQSEL	(0x30)	*/
 	0x00, /* REG_DTMF_TONEXT1H	(0x31)	*/
 	0x00, /* REG_DTMF_TONEXT1L	(0x32)	*/
-- 
1.5.6.5

  reply	other threads:[~2008-11-25 15:44 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-25 15:43 [PATCH 00/13] ASoC updates Mark Brown
2008-11-25 15:44 ` [PATCH 01/13] ASoC: Use supplied DAI for WM9713 rather than substream Mark Brown
2008-11-25 15:44   ` Mark Brown [this message]
2008-11-25 15:44     ` [PATCH 03/13] ASoC: TWL4030: Change the Master volume control to TLV Mark Brown
2008-11-25 15:44       ` [PATCH 04/13] ASoC: TWL4030: Add CGAIN volume control Mark Brown
2008-11-25 15:44         ` [PATCH 05/13] ASoC: TWL4030: Add helper function for output gain controls Mark Brown
2008-11-25 15:44           ` [PATCH 06/13] ASoC: Remove DAI type information Mark Brown
2008-11-25 15:44             ` [PATCH 07/13] ASoC: Flag AD1980 as an AC97 interface Mark Brown
2008-11-25 15:44               ` [PATCH 08/13] ASoC: Lower priority of resume work logging Mark Brown
2008-11-25 15:44                 ` [PATCH 09/13] ASoC: OMAP: Apply channel constrains to N810 machine driver Mark Brown
2008-11-25 15:44                   ` [PATCH 10/13] ASoC: OMAP: Add support for mono audio links in McBSP DAI Mark Brown
2008-11-25 15:44                     ` [PATCH 11/13] ASoC: Fix TWL4030 Kconfig dependency Mark Brown
2008-11-25 15:44                       ` [PATCH 12/13] ASoC: Add support for TI SDP3430 Mark Brown
2008-11-25 15:44                         ` [PATCH 13/13] ASoC: tosa: move gpio probing to machine callbacks Mark Brown
2008-11-25 15:58 ` [PATCH 00/13] ASoC updates Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1227627889-8373-2-git-send-email-broonie@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=peter.ujfalusi@nokia.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.