From: Ian Campbell <ijc@hellion.org.uk>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: "Stable Kernel" <stable@kernel.org>,
"Ingo Molnar" <mingo@elte.hu>,
"Daniel Schröder" <mail@dschroeder.info>,
"Yinghai Lu" <yinghai@kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: Change 5c371b31be3203 in stable breaks Xen
Date: Tue, 25 Nov 2008 23:06:04 +0000 [thread overview]
Message-ID: <1227654364.27529.3.camel@localhost.localdomain> (raw)
In-Reply-To: <492C6D8D.3040600@goop.org>
[-- Attachment #1: Type: text/plain, Size: 1890 bytes --]
On Tue, 2008-11-25 at 13:26 -0800, Jeremy Fitzhardinge wrote:
> I have a report of Xen breaking between 2.6.27.5 and .6. I bisected
> it
> down to change:
>
> commit 5c371b31be32033b0a4a993431484da8a2305369
> Author: Yinghai Lu <yhlu.kernel@gmail.com>
> Date: Mon Sep 22 02:52:26 2008 -0700
>
> x86: fix CONFIG_X86_RESERVE_LOW_64K=y
>
> commit 2216d199b1430d1c0affb1498a9ebdbd9c0de439 upstream
Looks like 5dc64a3442b98eaa0e3730c35fcf00cf962a93e7 might be needed in
stable too?
commit 5dc64a3442b98eaa0e3730c35fcf00cf962a93e7
Author: Ian Campbell <Ian.Campbell@citrix.com>
Date: Fri Oct 10 11:27:38 2008 +0100
xen: do not reserve 2 pages of padding between hypervisor and fixmap.
When reserving space for the hypervisor the Xen paravirt backend adds
an extra two pages (this was carried forward from the 2.6.18-xen tree
which had them "for safety"). Depending on various CONFIG options this
can cause the boot time fixmaps to span multiple PMDs which is not
supported and triggers a WARN in early_ioremap_init().
This was exposed by 2216d199b1430d1c0affb1498a9ebdbd9c0de439 which
moved the dmi table parsing earlier.
x86: fix CONFIG_X86_RESERVE_LOW_64K=y
The bad_bios_dmi_table() quirk never triggered because we do DMI setup
too late. Move it a bit earlier.
There is no real reason to reserve these two extra pages and the
fixmap already incorporates FIX_HOLE which serves the same
purpose. None of the other callers of reserve_top_address do this.
--
Ian Campbell
Moonchild without an opinion? Satan is skating to work tomorrow!
-- Brett Manz
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2008-11-25 23:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-25 21:26 Change 5c371b31be3203 in stable breaks Xen Jeremy Fitzhardinge
2008-11-25 23:06 ` Ian Campbell [this message]
2008-11-25 23:25 ` Jeremy Fitzhardinge
2008-11-26 0:03 ` [stable] " Greg KH
2008-11-26 20:41 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1227654364.27529.3.camel@localhost.localdomain \
--to=ijc@hellion.org.uk \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@dschroeder.info \
--cc=mingo@elte.hu \
--cc=stable@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.